chromeos::options::StorageManagerHandler::UpdateDriveCacheSize |
||||||||||||||||
Issue descriptionGoogle Chrome 53.0.2785.15 (Official Build) dev (64-bit) Revision 0 Platform 8530.20.0 (Official Build) dev-channel samus What steps will reproduce the problem? 1. Enter Guest browsing mode 2. Open Settings 3. Click Storage Management What do you see instead? Browser crash Reproducible always.
,
Jul 19 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 21 2016
+abodenha
,
Jul 22 2016
Can't get a crash ID. I'm guessing something is expecting that settings will never get called from an incognito profile. Accessing storage management from guest mode doesn't make sense. We should probably just disable the button.
,
Jul 26 2016
,
Jul 26 2016
crash report:https://crash.corp.google.com/browse?stbtiq=494fdc4200000000#0 Steps To Reproduce: (1)Open settings window (2)Click on Device-> Storage management button
,
Jul 26 2016
,
Jul 26 2016
,
Jul 26 2016
Is this a regression?
,
Jul 26 2016
I don't think so. I think the storage manager is a new feature. Not sure why it wasn't a launch bug.
,
Jul 26 2016
mitsuji@ was there a launch bug for the new storage management stuff?
,
Jul 26 2016
Should this be a blocker?
,
Jul 27 2016
Here's the launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=591958
,
Jul 27 2016
,
Jul 27 2016
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1 commit ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1 Author: fukino <fukino@chromium.org> Date: Thu Jul 28 02:30:03 2016 Storage manager: Hide "Offline files" when Google Drive volume is not mounted. The "Google Drive" volume in Files app does not always exist. (e.g. Guest session, Supervised user, or disabled by setting.) Showing "Offline files" in storage manager doesn't make sense in such cases and causes a crash. We should hide "Offline files" item when Google Drive volume doesn't exist. BUG= 629347 TEST=manually tested on a guest user and a supervised user. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2184083002 Cr-Commit-Position: refs/heads/master@{#408315} [modify] https://crrev.com/ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1/chrome/browser/resources/options/chromeos/storage_manager.html [modify] https://crrev.com/ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1/chrome/browser/resources/options/chromeos/storage_manager.js [modify] https://crrev.com/ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
,
Jul 28 2016
,
Jul 29 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e99b5785da15f9d858c29548c5b46d8ac4b389a commit 6e99b5785da15f9d858c29548c5b46d8ac4b389a Author: Naoki Fukino <fukino@chromium.org> Date: Mon Aug 01 06:13:31 2016 Storage manager: Hide "Offline files" when Google Drive volume is not mounted. The "Google Drive" volume in Files app does not always exist. (e.g. Guest session, Supervised user, or disabled by setting.) Showing "Offline files" in storage manager doesn't make sense in such cases and causes a crash. We should hide "Offline files" item when Google Drive volume doesn't exist. BUG= 629347 TEST=manually tested on a guest user and a supervised user. TBR=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2184083002 Cr-Commit-Position: refs/heads/master@{#408315} (cherry picked from commit ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1) Review URL: https://codereview.chromium.org/2202483002 . Cr-Commit-Position: refs/branch-heads/2785@{#426} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/6e99b5785da15f9d858c29548c5b46d8ac4b389a/chrome/browser/resources/options/chromeos/storage_manager.html [modify] https://crrev.com/6e99b5785da15f9d858c29548c5b46d8ac4b389a/chrome/browser/resources/options/chromeos/storage_manager.js [modify] https://crrev.com/6e99b5785da15f9d858c29548c5b46d8ac4b389a/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
,
Aug 1 2016
,
Aug 12 2016
Chrome Os 54.0.2824.0/8696.0.0 samus Chrome Os 53.0.2785.55/8530.49.0 cyan |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by sdantul...@chromium.org
, Jul 19 2016