New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629333 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 624274
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.1% regression in sizes at 405157:405182

Project Member Reported by m...@chromium.org, Jul 18 2016

Issue description

See the link to graphs below.
 

Comment 1 by m...@chromium.org, Jul 18 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=629333

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgipzwuwoM


Bot(s) for this bug's original alert(s):

win

Comment 2 by m...@chromium.org, Jul 18 2016

Owner: dpranke@chromium.org
Suspecting this change:

commit	8524d4afab4f543f93d53f6e97c3c4e03502bfbd	
author	dpranke <dpranke@chromium.org>	Wed Jul 13 16:19:11 2016
committer	Commit bot <commit-bot@chromium.org>	Wed Jul 13 16:20:30 2016
Flip main remaining Win builders to GN.


Cc: dpranke@chromium.org brettw@chromium.org
Owner: brucedaw...@chromium.org
I think we think this is okay, because chrome_child.dll shrinks by a larger amount than chrome.dll grows.

@brucedawson, can you confirm this and WontFix if appropriate?
see also  bug 624274  .
oh, I see now that this is from last Wednesday. Timely!

Regardless, same observation applies.
Mergedinto: 624274
Status: Duplicate (was: Assigned)
Yeah, it's a duplicate of 624274. I'm making some progress on shrinking chrome.dll and should at least be able to get it closer.

Linking is a more chaotic process than I would have imagined, but some of the big contributors should be avoidable.

Sign in to add a comment