New issue
Advanced search Search tips

Issue 629285 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Save-Page-As-Complete-Html can trigger an http auth dialog

Project Member Reported by lukasza@chromium.org, Jul 18 2016

Issue description

Repro:
1. Navigate to a webpage that includes an resource requiring http auth
2. Save-Page-As the page as "complete html"

Expected: no auth dialog???

Actual: auth dialog (trigerred by a new resource request created by SavePackage and SaveFileManager for saving the image resource)
 
This bug is a follow-up to a test request in a code review comment at https://codereview.chromium.org/2075273002/diff/1/content/browser/loader/resource_dispatcher_host_impl.cc#newcode1915

It turns out that save-page-as does trigger an auth dialog (in complete-html mode;  mhtml mode never issues new resource requests and so doesn't trigger an auth dialog).

I am not sure if the auth dialog is desirable or not.  I think one could argue both ways.  In any case - let's use this bug to decide what to do and record our arguments and reasoning.

FWIW, I have a draft of a test that highlights mhtml and complete-html behavior at https://codereview.chromium.org/2155333002.

Comment 2 by tkent@chromium.org, Aug 31 2016

Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 31 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by asanka@chromium.org, Aug 31 2017

Cc: -asanka@chromium.org

Sign in to add a comment