chrome crashes when touching screen with two fingers |
||||||
Issue description54.0.2798.0 Repro step: Keep tuoching (touch/release) using two fingers. It's crashing in GestureDetector::IsWithinTouchSlop https://cs.chromium.org/chromium/src/ui/events/gesture_detection/gesture_detector.cc?rcl=0&l=550 // Check if the primary pointer exceeded the slop region. float dx = current_down_event_->GetX() - ev.GetX(ev_idx0); When it crashes, ev_idx0 is 1 while there is only one touch point in event. I could not reproduce 52. I don't know when this was regressed. (must be in 53 or 54)
,
Jul 19 2016
Suspecting sahel@'s change for respecting slop with two fingers. Sahel, can you take a look?
,
Jul 19 2016
Good catch! I'll fix the bug.
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4479b653205f98f226e7f5d4cf1c6a78897ca97f commit 4479b653205f98f226e7f5d4cf1c6a78897ca97f Author: sahel <sahel@chromium.org> Date: Tue Jul 26 15:35:26 2016 The helper functions for slop region check and subtraction are modified. The unit test crashes in the old version and passes in the new patch. BUG= 629278 TEST=GestureProviderTest.ScrollStartWithSecondaryPointer Review-Url: https://codereview.chromium.org/2175803002 Cr-Commit-Position: refs/heads/master@{#407808} [modify] https://crrev.com/4479b653205f98f226e7f5d4cf1c6a78897ca97f/ui/events/gesture_detection/gesture_detector.cc [modify] https://crrev.com/4479b653205f98f226e7f5d4cf1c6a78897ca97f/ui/events/gesture_detection/gesture_detector.h [modify] https://crrev.com/4479b653205f98f226e7f5d4cf1c6a78897ca97f/ui/events/gesture_detection/gesture_provider.cc [modify] https://crrev.com/4479b653205f98f226e7f5d4cf1c6a78897ca97f/ui/events/gesture_detection/gesture_provider_unittest.cc [modify] https://crrev.com/4479b653205f98f226e7f5d4cf1c6a78897ca97f/ui/events/test/motion_event_test_utils.cc [modify] https://crrev.com/4479b653205f98f226e7f5d4cf1c6a78897ca97f/ui/events/test/motion_event_test_utils.h
,
Jul 26 2016
,
Jul 26 2016
No need to merge to 53?
,
Jul 26 2016
The patch with slop region check didn't land until M54.
,
Aug 23 2016
,
Sep 27 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sadrul@chromium.org
, Jul 18 2016Owner: tdres...@chromium.org