New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629261 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Single value significance test is not correctly bypassing MWU

Project Member Reported by robert...@chromium.org, Jul 18 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/20afb69fcdd21aac7c227cdea4799f05af0b9677

commit 20afb69fcdd21aac7c227cdea4799f05af0b9677
Author: robertocn <robertocn@chromium.org>
Date: Wed Jul 20 16:48:08 2016

Parameters to significantly_different.py need to be parsed as lists.

This change addresses a problem with the single-value check that
bypasses MWU. The parameters list_a and list_b are sent to this script
via the command line, and therefore are sent as strings. Before making
the check we need to parse them.

R=eakuefner@chromium.org,dtu@chromium.org
BUG= 629261 

Review-Url: https://codereview.chromium.org/2158413003

[modify] https://crrev.com/20afb69fcdd21aac7c227cdea4799f05af0b9677/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py
[modify] https://crrev.com/20afb69fcdd21aac7c227cdea4799f05af0b9677/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/601fee2d404223d03d452db6dd45f6fc567febb3

commit 601fee2d404223d03d452db6dd45f6fc567febb3
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 20 17:06:25 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/20afb69fcdd21aac7c227cdea4799f05af0b9677 Parameters to significantly_different.py need to be parsed as lists. (robertocn@chromium.org)

R=eakuefner@chromium.org,robertocn@chromium.org,dtu@chromium.org
BUG= 629261 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2163903003

[modify] https://crrev.com/601fee2d404223d03d452db6dd45f6fc567febb3/infra/config/recipes.cfg

Issue 629286 has been merged into this issue.
Status: Fixed (was: Assigned)
Components: Speed>Bisection

Sign in to add a comment