New issue
Advanced search Search tips

Issue 629255 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Migrate ShelfTooltipManager to wm common types

Project Member Reported by jamescook@chromium.org, Jul 18 2016

Issue description

WindowObserver -> WmWindowObserver
Window parenting GetWidgetInitParamsForContainer
It’s a pre-target handler, maybe extract into separate class? eliminate?

 

Comment 1 by msw@chromium.org, Jul 23 2016

Owner: msw@chromium.org
Status: Started (was: Available)
WIP CL: https://codereview.chromium.org/2176813002/
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d55249c4cf653a3c699764e37658b4ba1e11710

commit 7d55249c4cf653a3c699764e37658b4ba1e11710
Author: msw <msw@chromium.org>
Date: Tue Jul 26 22:05:55 2016

mash: Migrate ShelfTooltipManager to wm common types.

ShelfLayoutManagerObserver -> WmShelfObserver
Use OnBeforeBubbleWidgetInit for display/container init.

Add WmWindow::Add[Remove]LimitedPreTargetHandler
(only supports that window itself, not embedded windows)

Make it a pre-target handler for the shelf WmWindow.
(as opposed to the root aura window for the display)

BUG= 629255 
TEST=Automated tests; no shelf tooltip behavior changes.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2176813002
Cr-Commit-Position: refs/heads/master@{#407927}

[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/ash.gyp
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/aura/wm_window_aura.h
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/common/shelf/DEPS
[rename] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/common/shelf/shelf_tooltip_manager.cc
[rename] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/common/shelf/shelf_tooltip_manager.h
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/common/wm_window.h
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/shelf/shelf_view.h
[modify] https://crrev.com/7d55249c4cf653a3c699764e37658b4ba1e11710/ash/shelf/shelf_view_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4638c97183ade3deead0b9a53a7c69550ca05f6

commit c4638c97183ade3deead0b9a53a7c69550ca05f6
Author: msw <msw@chromium.org>
Date: Mon Aug 01 18:08:01 2016

mash: Migrate shelf tooltip manager tests to ash/common.

Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)

BUG= 629255 
TEST=automated
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2196933002
Cr-Commit-Position: refs/heads/master@{#408998}

[modify] https://crrev.com/c4638c97183ade3deead0b9a53a7c69550ca05f6/ash/ash.gyp
[modify] https://crrev.com/c4638c97183ade3deead0b9a53a7c69550ca05f6/ash/common/shelf/DEPS
[rename] https://crrev.com/c4638c97183ade3deead0b9a53a7c69550ca05f6/ash/common/shelf/shelf_tooltip_manager_unittest.cc

Comment 4 by msw@chromium.org, Aug 1 2016

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 7 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment