New issue
Advanced search Search tips

Issue 629254 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Migrate ShelfLockingManager to wm common types

Project Member Reported by jamescook@chromium.org, Jul 18 2016

Issue description

This may require a wrapper around LockStateController / LockStateObservers.

Maybe migrate LockStateObservers to be owned by WmShell?

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0afa16d52f12081bbc2a780d2fef2943ff34cd7

commit a0afa16d52f12081bbc2a780d2fef2943ff34cd7
Author: msw <msw@chromium.org>
Date: Wed Jul 20 21:26:08 2016

mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Move ShelfLockingManager test access to Shelf/WmShelf.

BUG= 629254 
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2166043003
Cr-Commit-Position: refs/heads/master@{#406671}

[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/ash.gyp
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/aura/wm_shelf_aura.h
[rename] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/common/shelf/shelf_locking_manager.cc
[rename] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/common/shelf/shelf_locking_manager.h
[rename] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/common/shelf/shelf_locking_manager_unittest.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/common/shelf/wm_shelf.h
[rename] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/common/wm/lock_state_observer.h
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/common/wm_shell.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/common/wm_shell.h
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/shelf/shelf.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/shelf/shelf.h
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/test/shelf_test_api.h
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/ash/wm/lock_state_controller.h
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7/chrome/browser/chromeos/login/lock/webui_screen_locker.h

Comment 2 by msw@chromium.org, Jul 20 2016

Status: Fixed (was: Available)
Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment