New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629250 link

Starred by 1 user
Status: Archived
Owner:
jamescook@chromium.org
Closed: Jul 2016
Cc:
msw@chromium.org
█ mfomitchev@chromium.org
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Migrate AppListButton and AppListShelfItemDelegate to wm common types

Project Member Reported by jamescook@chromium.org, Jul 18 2016 
AppListButton
Needs ShelfWidget, ShelfView, ShelfLayoutManager
Convert to WmShelf for alignment
Shell::IsApplistVisible -- get it from AppListPresenter (via ShellDelegate)

AppListShelfItemDelegate
inject ShelfModel instead of ash::Shell, or move ShelfModel to WmShell (or WmShelf)

Comment 1 Deleted

Comment 2 by jamescook@chromium.org, Jul 20 2016

Cc: -jamescook@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Available)

Comment 3 by jamescook@chromium.org, Jul 20 2016

Cc: sky@chromium.org
Accelerator handling for the app list can move back to accelerator_commands.cc when this lands.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abe9e24cab6f3245c8583d773644d3b62d84d71a

commit abe9e24cab6f3245c8583d773644d3b62d84d71a
Author: jamescook <jamescook@chromium.org>
Date: Wed Jul 20 20:03:59 2016

mash: Migrate shelf app list button to wm common types

This is needed to port the shelf to mash.

* Move app list show/hide/visible functions to WmShell
* Remove window parameter from ShowAppList/ToggleAppList because non-test
code always shows and hides on the default display
* Migrate ShelfModel ownership to WmShell

BUG= 629250 
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2169533002
Cr-Commit-Position: refs/heads/master@{#406646}

[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/accelerators/accelerator_delegate.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/ash.gyp
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/common/shelf/DEPS
[rename] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/common/shelf/app_list_button.cc
[rename] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/common/shelf/app_list_button.h
[rename] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/common/shelf/app_list_shelf_item_delegate.cc
[rename] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/common/shelf/app_list_shelf_item_delegate.h
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/common/wm_shell.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/common/wm_shell.h
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/first_run/first_run_helper_impl.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shelf/shelf_view.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shell.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shell.h
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shell/app_list.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/shell/window_watcher.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/test/shell_test_api.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/abe9e24cab6f3245c8583d773644d3b62d84d71a/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc

Comment 5 by jamescook@chromium.org, Jul 20 2016

Status: Fixed (was: Started)
sky, the accelerator stuff can move back now. Let me know if you want me to move the applist accelerator stuff back, or if you would like to do it.

Comment 6 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 7 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 8 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 9 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 13 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment