New issue
Advanced search Search tips

Issue 629248 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Overflow bubble support

Project Member Reported by jamescook@chromium.org, Jul 18 2016

Issue description

Migrate to wm common types: OverflowBubble, OverflowBubbleView, OverflowButton

OverflowBubble
Uses Shell for AddPointerWatcher, move to WmShell

OverflowBubbleView
Not too hard
Widget parenting to WmLookup
Alignment to WmShelf

OverflowButton
WmShelf for alignment, background type

 
Cc: -jamescook@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a5416dc6f83c74fd820c44ace39154698b0648c

commit 8a5416dc6f83c74fd820c44ace39154698b0648c
Author: jamescook <jamescook@chromium.org>
Date: Tue Jul 19 20:04:24 2016

mash: Convert ash shelf overflow bubble to wm common types

* Convert files to use WmShelf
* Eliminate ash::Shell and RootWindowController refs
* Move files to //ash/common

This allows a DEP on ShelfView as that class has dependencies back on the
overflow bubble and will need to move later.

No functional changes.

BUG= 629248 
TEST=ash_unittests, chrome unit_tests, manually open overflow bubble and quit
chrome, add secondary monitor, etc.

Review-Url: https://codereview.chromium.org/2164733002
Cr-Commit-Position: refs/heads/master@{#406359}

[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/ash.gyp
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/aura/wm_shelf_aura.h
[add] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/DEPS
[rename] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/ink_drop_button_listener.h
[rename] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/overflow_bubble.cc
[rename] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/overflow_bubble.h
[rename] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/overflow_bubble_view.cc
[rename] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/overflow_bubble_view.h
[rename] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/overflow_button.cc
[rename] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/overflow_button.h
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/shelf/app_list_button.cc
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/shelf/shelf_button.cc
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/shelf/shelf_view.cc
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/shelf/shelf_view.h
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/test/overflow_bubble_view_test_api.cc
[modify] https://crrev.com/8a5416dc6f83c74fd820c44ace39154698b0648c/ash/test/shelf_view_test_api.cc

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment