New issue
Advanced search Search tips

Issue 629244 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Move shelf delegates and observers to //ash/common

Project Member Reported by jamescook@chromium.org, Jul 18 2016

Issue description

This is a mechanical move of:
ShelfDelegate, ShelfIconObserver, ShelfLayoutManagerObserver

 
Cc: -jamescook@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Available)
I'm changing the ownership of ShelfDelegate from ash::Shell to WmShell.

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff5220bf49573c720e26bfa025011fa198038f27

commit ff5220bf49573c720e26bfa025011fa198038f27
Author: jamescook <jamescook@chromium.org>
Date: Mon Jul 25 17:07:53 2016

mash: Move ownership of ShelfDelegate to WmShell

This removes some ash::Shell access in the shelf, which we need to eliminate
to port to mus.

* Move ShelfDelegate to //ash/common
* Move ownership to WmShell
* Move ShelfDelegate creation slightly earlier by doing it on Shelf creation,
rather than lazily on access. It can't happen in WmShell::Initialize() because
Chrome's implementation depends on the user being logged in.

TODO: Fix ash::ShelfWindowWatcher ownership and creation time.

BUG= 629244 
TEST=ash_unittests, chrome unit_tests and browser_tests
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2177663002
Cr-Commit-Position: refs/heads/master@{#407497}

[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/ash.gyp
[rename] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/common/shelf/shelf_delegate.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/common/wm_shell.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/common/wm_shell.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shelf/shelf.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shelf/shelf.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shelf/shelf_view.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shell.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shell.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/shell/shelf_delegate_impl.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/sysui/shelf_delegate_mus.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/sysui/sysui_application.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/test/shelf_test_api.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/test/shell_test_api.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/test/shell_test_api.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/ash/test/test_shelf_delegate.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/ff5220bf49573c720e26bfa025011fa198038f27/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

Status: Fixed (was: Started)
I think we'll do the other ones as we convert the pieces of code that use them.

Labels: VerifyIn-54
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment