New issue
Advanced search Search tips

Issue 629227 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 631409
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

0.1%-66.3% regression in sizes at 405185:405927

Project Member Reported by m...@chromium.org, Jul 18 2016

Issue description

Sizes seems to increase whenever "Updating trunk VERSION from X to Y". That seems bogus.
 

Comment 2 by m...@chromium.org, Jul 18 2016

Labels: -Pri-2 -Performance-Sheriff Performance-Sheriff-BotHealth Pri-1
Owner: ----
Status: Available (was: Assigned)
Looks like the mac bot is not measuring "sizes" correctly. See initial description (at top).
Owner: tapted@chromium.org
tapted, as sizes owner on Mac, can you take a look?

Comment 4 by tapted@chromium.org, Jul 19 2016

Cc: sullivan@chromium.org
Hm

> Sizes seems to increase whenever "Updating trunk VERSION from X to Y". That seems bogus.
$ ls /Applications/Google\ Chrome.app/Contents/Versions/
53.0.2783.5/ 53.0.2785.8/

The sizes bot should probably be doing clobber builds, or at least `rm -r out/[Release]/Google\ Chrome.app`. sullivan@ - do you know where the bot config for the bot we care about is?

But there's little outside of the versioned subfolder that we care about (for me it's 828kB worth), we could probably adjust sizes.py to only read the most recent version without losing too much.
Cc: dtu@chromium.org
+dtu - I think we do non-clobber builds because it's faster (and we want to do a build per revision), right? Is removing Google Chrome.app an option?
Mergedinto: 631409
Status: Duplicate (was: Available)
Came across this while sheriffing. Dupe of  Issue 631409 
I think mark just fixed this in https://codereview.chromium.org/2179013002

Sign in to add a comment