Issue metadata
Sign in to add a comment
|
0.1%-66.3% regression in sizes at 405185:405927 |
||||||||||||||||||||||
Issue descriptionSizes seems to increase whenever "Updating trunk VERSION from X to Y". That seems bogus.
,
Jul 18 2016
Looks like the mac bot is not measuring "sizes" correctly. See initial description (at top).
,
Jul 18 2016
tapted, as sizes owner on Mac, can you take a look?
,
Jul 19 2016
Hm > Sizes seems to increase whenever "Updating trunk VERSION from X to Y". That seems bogus. $ ls /Applications/Google\ Chrome.app/Contents/Versions/ 53.0.2783.5/ 53.0.2785.8/ The sizes bot should probably be doing clobber builds, or at least `rm -r out/[Release]/Google\ Chrome.app`. sullivan@ - do you know where the bot config for the bot we care about is? But there's little outside of the versioned subfolder that we care about (for me it's 828kB worth), we could probably adjust sizes.py to only read the most recent version without losing too much.
,
Jul 19 2016
+dtu - I think we do non-clobber builds because it's faster (and we want to do a build per revision), right? Is removing Google Chrome.app an option?
,
Jul 26 2016
Came across this while sheriffing. Dupe of Issue 631409 I think mark just fixed this in https://codereview.chromium.org/2179013002 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by m...@chromium.org
, Jul 18 2016