chrome.feedback.feedbackPrivate should respect the productId provided if it is valid |
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 Steps to reproduce the problem: 1. Use chrome.feedback.feedbackPrivate to file any google feedback report with the "productId" field set Feedback ends up in either feedback product 208 or 237 (depending on whether Chrome was built for ChromeOS). What is the expected behavior? The productId set in the call to feedbackPrivate should be used if it was provided (so that the report ends up in the correct feedback product). What went wrong? Chrome uses hard-coded values (208 for ChromeOS and 237 for everything else). Did this work before? No Chrome version: 51.0.2704.106 Channel: stable OS Version: Flash Version: Shockwave Flash 22.0 r0 There are existing usages of this API passing invalid values. (For example, arbitrary text strings). To avoid breaking them, the change should gracefully degrade for invalid values. e.g. - If no productId is provided, fall back to existing behavior - If a productId is provided, but does not parse as a number, log an error and fall back to existing behavior - If a productId is provided and parses as a number, use that.
,
Jul 19 2016
,
Jul 20 2016
Marking it as Untriaged as it is a feature request. Thanks you!
,
Jul 22 2016
,
Jul 27 2016
I'll fix this soon.
,
Jul 28 2016
,
Jul 29 2016
The product ID is defined as an integer in the server as well as in the FeedbackData in the Chrome src. The FeedbackInfo was never updated accordingly. This will be fixed as part of this CL.
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/402fadf2aa66df46406f46dbde4d69a93d9a4a7e commit 402fadf2aa66df46406f46dbde4d69a93d9a4a7e Author: afakhry <afakhry@chromium.org> Date: Wed Aug 03 22:27:42 2016 Sent feedback reports must respect the product ID if any was provided The product ID used to be ignored and the reports were sent using a default value depending on either chrome or chromeos. The product ID has an integer type, yet in the FeedbackInfo, it was never updated and still had a string type. This CL fixes these issues. BUG= 629172 TEST=components_unittests --gtest_filter=FeedbackCommonTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2189353003 Cr-Commit-Position: refs/heads/master@{#409641} [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/chrome/browser/resources/feedback/OWNERS [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/chrome/browser/resources/feedback/js/feedback.js [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/chrome/common/extensions/api/feedback_private.idl [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/components/feedback/OWNERS [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/components/feedback/feedback_common.cc [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/components/feedback/feedback_common.h [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/components/feedback/feedback_common_unittest.cc [modify] https://crrev.com/402fadf2aa66df46406f46dbde4d69a93d9a4a7e/components/feedback/feedback_util.cc
,
Aug 4 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jdeokule@chromium.org
, Jul 18 2016Owner: afakhry@chromium.org