New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629140 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
(slow to respond to bugs. if it's i...
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature
Team-Security-UX

Blocked on:
issue 650325

Blocking:
issue 644990



Sign in to add a comment

Update interstitials to match the new security indicators

Project Member Reported by f...@chromium.org, Jul 18 2016

Issue description

Attached mocks from Max
 
Interstitials.png
338 KB View Download

Comment 1 by f...@chromium.org, Jul 18 2016

Screenshots of implementation
Screen Shot 2016-07-18 at 10.26.38 AM.png
405 KB View Download
Screen Shot 2016-07-18 at 10.26.46 AM.png
390 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a

commit bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a
Author: felt <felt@chromium.org>
Date: Tue Jul 19 02:04:12 2016

Update interstitials to match the new security indicators

I've gated this change using the Feature API, behind the feature name
SecurityWarningIconUpdate. That way we can monitor the CTR impact and
roll back if necessary.

Squashed pngs using tools/resources/optimize-png-files.sh -o2.

Screenshots on the bug.

BUG= 629140 

Review-Url: https://codereview.chromium.org/2158113002
Cr-Commit-Position: refs/heads/master@{#406183}

[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/chrome/browser/ssl/captive_portal_blocking_page.cc
[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/bad_clock_ui.cc
[add] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/browser/resources/images/1x/triangle_red.png
[add] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/browser/resources/images/1x/triangle_white.png
[add] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/browser/resources/images/2x/triangle_red.png
[add] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/browser/resources/images/2x/triangle_white.png
[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/browser/resources/interstitial_v2.css
[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/browser/resources/interstitial_v2.js
[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/common_string_util.cc
[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/common_string_util.h
[modify] https://crrev.com/bd00bd10a193ca94ba6145cdba65f4e3f0a2cc6a/components/security_interstitials/core/ssl_error_ui.cc

Comment 3 by f...@chromium.org, Jul 19 2016

Status: Fixed (was: Started)

Comment 4 by f...@chromium.org, Aug 30 2016

Cc: f...@chromium.org palmer@chromium.org
 Issue 602671  has been merged into this issue.
Labels: Hotlist-SecurityIndicators
I'm going wild and adding `Hotlist-SecurityIndicators` for anything should be in sync with the `Hotlist-SecurityIndicators` so we can keep track of leftover work more easily.
Feel free to push back if you think this is not related enough to merit the label. ;-)
Also, the new indicators don't show up on interstitials for the Dev channel (Chrome 54.0.2837.0, OSX 10.11.6). Is that expected due to the experiment mentioned in the commit?

Comment 7 by f...@chromium.org, Aug 30 2016

Re #6: yes, that's why. I need to push the experimental config along but the finch dash has been broken.

Comment 9 by f...@chromium.org, Sep 8 2016

Blocking: 644990
Blockedon: 650325
Components: UI>Browser>Omnibox>SecurityIndicators
Components: -Security>UX
Labels: -Hotlist-SecurityIndicators

Sign in to add a comment