New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629137 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[wifi_attenperf] Tests "network_WiFi_AttenuatedPerf.ht40_ch011 & network_WiFi_AttenuatedPerf.ht40_ch001 " fail with Attribute Error

Project Member Reported by aashuto...@chromium.org, Jul 18 2016

Issue description


https://wmatrix.googleplex.com/platform/unfiltered?suites=wifi_atten_perf&days_back=30&releases=53&platforms=daisy
https://wmatrix.googleplex.com/platform/unfiltered?suites=wifi_atten_perf&days_back=30&releases=54&platforms=daisy

Sample failures:
07/15 18:59:04.623 WARNI|              test:0606| Autotest caught exception when running test:
Traceback (most recent call last):
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/client/common_lib/test.py", line 600, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/client/common_lib/test.py", line 810, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled AttributeError: 'NoneType' object has no attribute 'exit_status'
Traceback (most recent call last):
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/client/common_lib/test.py", line 804, in _call_test_function
    return func(*args, **dargs)
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/client/common_lib/test.py", line 461, in execute
    dargs)
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/client/common_lib/test.py", line 347, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/client/common_lib/test.py", line 376, in _call_run_once
    self.run_once(*args, **dargs)
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py", line 89, in run_once
    results = session.run(config)
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/server/cros/network/netperf_session.py", line 112, in run
    result = runner.run(ignore_failures=self._ignore_failures)
  File "/tmp/daisy_8530.0.0_dev_Autotest/chromeos-hwqual-daisy-R53-8530.0.0/autotest/server/cros/network/netperf_runner.py", line 577, in run
    if result.exit_status and not ignore_failures:
AttributeError: 'NoneType' object has no attribute 'exit_status'

07/15 18:59:04.624 INFO |       wifi_client:1302| ======= WiFi autotest complete. Cleaning up... =======

                                   
More results @ 
https://uberchromeos-server38.corp.google.com/new_tko/#tab_id=table_view&columns=test_idx%252Ctest_name%252Cjob_tag%252Chostname%252Cstatus%252CDATE(test_finished_time)%252Creason%252Cplatform&sort=-DATE(test_finished_time)%252Ctest_idx&condition=(((test_name+%253D+%2527network_WiFi_AttenuatedPerf.ht40_ch001%2527)+AND+(%2560status%2560+%253D+%2527FAIL%2527)+AND+(%2560reason%2560%253D%2527Unhandled+AttributeError%253A+%255C%2527NoneType%255C%2527+object+has+no+attribute+%255C%2527exit_status%255C%2527%2527)))&show_invalid=false&parameterized_field_0_type=Test+label&parameterized_field_0_value=invalidated 


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 19 2016

Labels: -M-53 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: kirtika@chromium.org
Cc: aashuto...@chromium.org snanda@chromium.org
 Issue 599726  has been merged into this issue.
Cc: harpreet@chromium.org
Owner: briannorris@chromium.org
Status: Started (was: Untriaged)
Looking at this test for other reasons, and it looks trivial to fix.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7eb0f3bc7ab0642dab5aa562828748f21f717db6

commit 7eb0f3bc7ab0642dab5aa562828748f21f717db6
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Oct 05 01:47:06 2017

netperf_runner: fixup error handling for 'None' results

We access the 'result.exit_status' field before checking if it's None.
That's broken.

Reorganize the ignore_failures vs. !ignore_failures logic a bit, and
add a new TestFail() condition for when we get no results and haven't
asked for 'ignore_failures=True'.

BUG= chromium:629137 
TEST=network_AttenuatedPerf, with high attenuation (causing association
     failures on certain boards)

Change-Id: I7881391eed3bb10a8b58573e1567a6c3e5aaea0b
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/696267
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/7eb0f3bc7ab0642dab5aa562828748f21f717db6/server/cros/network/netperf_runner.py

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Status: Verified (was: Fixed)

Sign in to add a comment