100s of LayoutTests fail on Linux after b0df9e3fcb |
||||
Issue descriptionVersion: b0df9e3fcbca19d2a625fa274172bd3be4116261 OS: Linux What steps will reproduce the problem? (1) python third_party/WebKit/Tools/Scripts/run-webkit-tests What is the expected output? Test PASS. What do you see instead? Tests FAIL: [1506/38895] virtual/gpu-ras...mate-rotate.html failed unexpectedly (image diff) [1603/38895] virtual/rootlay...ombinations.html failed unexpectedly ...... See thread on blink-dev: https://groups.google.com/a/chromium.org/forum/?pli=1#!topic/blink-dev/kOnyZUSb61w Bisect points to hubbe's b0df9e3fcbca19d2a625fa274172bd3be4116261 If you look at the failures, the difference is color being slightly off. Since this patch is retreiving the monitor color space, it all makes sense. And the CR comment says: "This may change a bazillion layout tests on Linux." Please fix, this makes running local LayoutTests on Linux impossible.
,
Jul 18 2016
This seems like it should be higher than P3 since I believe most Blink eng work on Linux and would frequently sanity check changes locally before running on remote bots which is much more time intensive? Thanks to atotic@ for bisecting.
,
Jul 18 2016
Shall we go forward with a revert while we figure out how to make layout tests have a pre-defined profile?
,
Jul 18 2016
I wonder how many people this affects though. Using ICC profiles on linux is relatively rare I thought.
,
Jul 18 2016
I've never calibrated my display, or set the ICC profile. Running Unity, 2 monitors, one is 40" 4K.
,
Jul 18 2016
I'm using everything out of box as well, and I believe I've seen pdr@ and chrishtr@ experience these errors recently.
,
Jul 18 2016
Reverting CL until we can work around the layout test issue.
,
Jul 19 2016
,
Sep 22 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, Jul 18 2016