New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629098 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 628268
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.8%-18.3% regression in system_health.memory_mobile at 405124:405139

Project Member Reported by petrcermak@chromium.org, Jul 18 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 18 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean       Std Dev   N   Good?
chromium@405123  121804445  10072768  12  good
chromium@405139  123079325  6790003   12  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 629098

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_news-memory:chrome:all_processes:reported_by_os:system_memory:native_heap:private_dirty_size_avg/load_news_cnn
Relative Change: 7.28%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/808
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006786114942911600


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5865487674638336

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jul 20 2016

Mergedinto: 628268
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add benchmark that imitates news reading.
Author  : ulan
Commit description:
  
Each story in the benchmark does the following:
1. Load the main page.
2. Open and scroll the first news item.
3. Go back to the main page and scroll it.
4. Open and scroll the second news item.
5. Go back to the main page and scroll it.
6. etc.

This workflow is interesting because it is close to real world
and generates a lot of garbage by creating and discarding pages.

A couple of websites crash with OOM on svelte device, so by
tracking and optimizing for this benchmark we can improve
user experience on low-memory devices.

*** NOTE TO SHERRIF ***
Regressions are expected in system_health.memory_mobile and
system_health.memory_desktop for the following stories:
- load:news:cnn
- load:social:facebook
- load:news:qq
- load:news:reddit
- load:social:twitter

If there are failing tests in form of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*
please do not revert this CL but instead disabling failing
test by adding them into the _DISABLE_TESTS list in
tools/perf/benchmarks/system_health_smoke_test.py

BUG=589726
CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2118293002
Cr-Commit-Position: refs/heads/master@{#405212}
Commit  : 5b1847df818e5be4592e9a6ac4832350bb663023
Date    : Wed Jul 13 17:39:28 2016


===== TESTED REVISIONS =====
Revision         Mean       Std Dev  N   Good?
chromium@405123  148963656  8944296  8   good
chromium@405196  147435336  7200083  8   good
chromium@405205  148392605  9242740  12  good
chromium@405210  148799816  8457000  12  good
chromium@405211  143320802  7418528  5   good
chromium@405212  159645341  1754758  12  bad    <--
chromium@405214  158699507  2291959  12  bad
chromium@405232  161082696  3096309  5   bad
chromium@405268  159996744  1126057  8   bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 629098

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_news-memory:chrome:all_processes:reported_by_os:system_memory:private_dirty_size_avg/load_news_cnn
Relative Change: 5.28%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/812
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006718933357169792


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5839117783400448

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment