New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629095 link

Starred by 2 users
Status: Fixed
Owner:
riajiang@chromium.org
Closed: Aug 2017
Cc:
█ ben@chromium.org
dmazz...@chromium.org
sadrul@chromium.org
riajiang@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: 2017-01-31
OS: ----
Pri: 2
Type: Bug
Team-Accessibility

Blocked on:
issue 628663
issue 628665
Blocking:
issue 594887
issue 557401



Sign in to add a comment

autoclick should become a separate app

Project Member Reported by sadrul@chromium.org, Jul 18 2016 
The autoclick functionality in chromeos should become a separate app in mus+ash world. AutoclickRingHandler should move into //ash/autoclick/, the EventHandler part in ash/autoclick/autoclick_controller.cc should move into a separate place, so that autoclick_controller can be fed events from the outside. This way, we can use the existing ui::EventHandler for feeding it events from ash::Shell in classic-ash, but use an EventObserver instead in mus+ash.

This would be similar to the touch_hud app, where the core code lives in //ash/touch_hud, which is used by classic-ash and a mus app (which lives in //ash/touch_hud/mus).

More at: https://docs.google.com/document/d/15d2hBjqpAl0ax2rwjftBhj2ib1-CwYTMYT30vW_nLwI/edit#heading=h.8p818irozpxi

Comment 1 by sadrul@chromium.org, Jul 26 2016

Owner: riajiang@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb5d899d60dab2d059772a08640424d25e229358

commit fb5d899d60dab2d059772a08640424d25e229358
Author: riajiang <riajiang@chromium.org>
Date: Wed Aug 17 22:19:37 2016

ash: Refactor autoclick common code to ash/autoclick/common.

BUG= 629095 
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2193563002
Cr-Commit-Position: refs/heads/master@{#412668}

[modify] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/BUILD.gn
[modify] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/autoclick_controller.h
[add] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/common/BUILD.gn
[add] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/common/DEPS
[add] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/common/autoclick_controller_common.cc
[add] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/common/autoclick_controller_common.h
[add] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/common/autoclick_controller_common_delegate.h
[rename] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/common/autoclick_ring_handler.cc
[add] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/ash/autoclick/common/autoclick_ring_handler.h
[delete] https://crrev.com/5557376bb5137162c103b765680acc8567751e26/chrome/browser/chromeos/ui/autoclick_ring_handler.h
[modify] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/fb5d899d60dab2d059772a08640424d25e229358/chrome/chrome_browser_chromeos.gypi
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b626b97740da69f18ba83cd194189fbbe02b608

commit 4b626b97740da69f18ba83cd194189fbbe02b608
Author: riajiang <riajiang@chromium.org>
Date: Tue Sep 13 16:12:49 2016

mash: Add autoclick app.

TODO:
1.  crbug.com/628665 : mus: Allow accessibility clients to generate
some events. So right now this app can't actually click things
after the autoclick delay time is up.
2. crbug.com/608547: Deprecate ui::Event::root_location and replace
it with ui::Event::screen_location. The autoclick ring widget
position is a bit off if the screen location of the event is
different from its location inside window.

BUG= 629095 
TEST=manual

Review-Url: https://codereview.chromium.org/2316553003
Cr-Commit-Position: refs/heads/master@{#418264}

[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/common/autoclick_controller_common.cc
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/common/autoclick_controller_common.h
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/common/autoclick_controller_common_delegate.h
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/BUILD.gn
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/DEPS
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/autoclick_application.cc
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/autoclick_application.h
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/main.cc
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/manifest.json
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/public/interfaces/BUILD.gn
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/public/interfaces/OWNERS
[add] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/ash/autoclick/mus/public/interfaces/autoclick.mojom
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/chrome/app/mojo/chrome_manifest.json
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/chrome/test/BUILD.gn
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/mash/package/BUILD.gn
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/mash/package/DEPS
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/mash/package/mash_packaged_service.cc
[modify] https://crrev.com/4b626b97740da69f18ba83cd194189fbbe02b608/mash/package/mash_packaged_service.h

Comment 4 by rjkroege@chromium.org, Oct 4 2016

Labels: Proj-Mustash

Comment 5 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS

Comment 6 by sadrul@chromium.org, Dec 9 2016

NextAction: 2017-01-31

Comment 7 by dmazz...@chromium.org, Mar 28 2017

Labels: NewComponent-Accessibility-Internals NewComponent-Accessibility

Comment 8 by dmazz...@chromium.org, Apr 21 2017

Components: Internals>Accessibility

Comment 9 by dmazz...@chromium.org, Apr 21 2017

Components: -UI>Accessibility
Labels: -newcomponent-accessibility-internals -newcomponent-accessibility

Comment 10 by dmazz...@chromium.org, Aug 11 2017

Labels: triage-dtseng

Comment 11 by dtseng@chromium.org, Aug 11 2017

Labels: -triage-dtseng
riajiang@, are you finished with this one? Mind closing?

Comment 12 by riajiang@chromium.org, Aug 16 2017

Status: Fixed (was: Started)

Comment 13 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 14 by lafo...@chromium.org, Feb 26 2018

Components: -MUS

Comment 15 by jamescook@chromium.org, Mar 13 2018

Blocking: 594887
►

Sign in to add a comment