New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629075 link

Starred by 5 users
Status: Fixed
Owner:
schenney@chromium.org
Closed: Jul 2016
Cc:
nyerramilli@chromium.org
schenney@chromium.org
█ msrchandra@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 463348



Sign in to add a comment

Regression: Border missing in some cases

Reported by krinklem...@gmail.com, Jul 18 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2799.0 Safari/537.36

Example URL:
https://en.wikipedia.org/wiki/User:Krinkle

Steps to reproduce the problem:
1. View https://en.wikipedia.org/wiki/User:Krinkle

What is the expected behavior?

What went wrong?
The right-side border of the top menu is missing.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes 

Chrome version: 54.0.2799.0  Channel: canary
OS Version: OS X 10.11.4
Flash Version: 

This seems to be a resurfacing of  issue 570611  and  issue 567196 .
wikipedia-capture.png
216 KB View Download
mediawiki-capture.png
211 KB View Download

Comment 1 by dtapu...@chromium.org, Jul 18 2016

Components: -Blink Blink>Paint

Comment 2 by dtapu...@chromium.org, Jul 18 2016

Components: -Blink>Paint Blink>Layout

Comment 3 by schenney@chromium.org, Jul 18 2016

Components: -Blink>Layout Blink>Paint
Owner: schenney@chromium.org
Status: Assigned (was: Unconfirmed)
This is probably a sub-pixel snapping problem painting the background image in the lower right corner of the span. I'll look.

Comment 4 by ebra...@gnu.org, Jul 18 2016

Blocking: 463348

Comment 5 by pdr@chromium.org, Jul 21 2016

Labels: -Type-Bug Type-Bug-Regression
This is a regression from https://chromium.googlesource.com/chromium/src/+/689f41251eab6e3812c09296a14cb1edc6db3b0e

Comment 6 by schenney@chromium.org, Jul 21 2016 

Yes. Given I'm the only one changing things, I'm no doubt the only one breaking things (not quite true, but almost).
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098ef3d2deef53dcd893961a87a0a96cd9bf276b

commit 098ef3d2deef53dcd893961a87a0a96cd9bf276b
Author: schenney <schenney@chromium.org>
Date: Thu Jul 21 21:21:21 2016

Fix the positioning of backgrounds positioned right and bottom

A recent change unnecessarily pixel snapped the destination rect
for background image painting before computing values determined by
that rectangle. This caused situations where subsequent sub-pixel
snapping pushes right and bottom positioned 1-pixel images outside
the dest rect when it is intersected with the paint rect.

The fix is to revert the line that early-snaps the dest rect.

New test added to cover this case. One other test that had got slightly
worse with the previous change gets better again with this change.

R=pdr@chromium.org
BUG= 629075 

Review-Url: https://codereview.chromium.org/2167323002
Cr-Commit-Position: refs/heads/master@{#406946}

[modify] https://crrev.com/098ef3d2deef53dcd893961a87a0a96cd9bf276b/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/098ef3d2deef53dcd893961a87a0a96cd9bf276b/third_party/WebKit/LayoutTests/css3/background/background-right-bottom-subpixel-position-expected.html
[add] https://crrev.com/098ef3d2deef53dcd893961a87a0a96cd9bf276b/third_party/WebKit/LayoutTests/css3/background/background-right-bottom-subpixel-position.html
[modify] https://crrev.com/098ef3d2deef53dcd893961a87a0a96cd9bf276b/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/560f8a3f14e120fa37b28926b082516c6d7ad99b

commit 560f8a3f14e120fa37b28926b082516c6d7ad99b
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Jul 21 23:29:28 2016

Auto-rebaseline for r406946

https://chromium.googlesource.com/chromium/src/+/098ef3d2d

BUG= 629075 
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/2174583002 .

Cr-Commit-Position: refs/heads/master@{#406989}

[modify] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/android/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png
[modify] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/linux/fast/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png
[modify] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/mac/fast/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png
[modify] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/win/fast/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png
[add] https://crrev.com/560f8a3f14e120fa37b28926b082516c6d7ad99b/third_party/WebKit/LayoutTests/platform/win7/fast/images/color-profile-background-image-space-expected.png

Comment 9 by schenney@chromium.org, Jul 22 2016

Cc: msrchandra@chromium.org schenney@chromium.org nyerramilli@chromium.org
 Issue 629413  has been merged into this issue.

Comment 10 by schenney@chromium.org, Jul 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment