New issue
Advanced search Search tips

Issue 629057 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Android MIPS Builder (dbg) broken (missing V8 dep)

Project Member Reported by lizeb@chromium.org, Jul 18 2016

Issue description

Android MIPS Builder (dbg) is broken since:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20MIPS%20Builder%20%28dbg%29/builds/5769

Error:

/b/build/slave/android_build/build/src/buildtools/linux64/gn gen //out/Debug --check
  -> returned 1
ERROR Unresolved dependencies.
//chrome/test:unit_tests_js_action(//build/toolchain/android:mipsel)
  needs //v8:v8_shell(//build/toolchain/linux:clang_x86_v8_mipsel)
//v8:run_mksnapshot(//build/toolchain/android:mipsel)
  needs //v8:mksnapshot(//build/toolchain/linux:clang_x86_v8_mipsel)


Suspected CL:
https://codereview.chromium.org/2158643002

(V8 roll)
 

Comment 1 by lizeb@chromium.org, Jul 18 2016

Labels: -Pri-3 OS-Android Pri-2
Owner: lizeb@chromium.org
Status: Assigned (was: lize)

Comment 2 by lizeb@chromium.org, Jul 18 2016

Cc: dpranke@chromium.org
Only V8 commit in range:
https://codereview.chromium.org/2116913002

Comment 3 by lizeb@chromium.org, Jul 18 2016

Cc: -dpranke@chromium.org lizeb@chromium.org yus...@chromium.org
Owner: dpranke@chromium.org
Status: Started (was: Assigned)
Yup, I should have a fix shortly ...
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb1cadc07b5b8f97f1ef5ee9800a47ce6f6fe902

commit fb1cadc07b5b8f97f1ef5ee9800a47ce6f6fe902
Author: dpranke <dpranke@chromium.org>
Date: Tue Jul 19 01:54:15 2016

Fix the v8 snapshots in the GN mipsel, mips64el builds.

This also deletes references to gcc-based snapshot toolchains that
don't actually exist. Let's find out if they're actually needed anywhere ;).
The mips build was broken by the v8_target_cpu changes for 625353.

TBR=machenbach@chromium.org
BUG= 625353 ,  629057 

Review-Url: https://codereview.chromium.org/2159003002
Cr-Commit-Position: refs/heads/master@{#406174}

[modify] https://crrev.com/fb1cadc07b5b8f97f1ef5ee9800a47ce6f6fe902/build/config/v8_target_cpu.gni
[modify] https://crrev.com/fb1cadc07b5b8f97f1ef5ee9800a47ce6f6fe902/build/toolchain/linux/BUILD.gn

Status: Fixed (was: Started)
Looks like we're good now (the builders have cycled past the failures in generate_build_files).

Sign in to add a comment