New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629049 link

Starred by 1 user
Status: Fixed
Owner:
lizeb@chromium.org
Closed: Jul 2016
Cc:
█ joh...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Android Webview L (dbg) and Android Webview M (dbg) broken (WebViewLayoutTest#testWebViewIncludedStableInterfaces)

Project Member Reported by lizeb@chromium.org, Jul 18 2016 
Android WebView bots are broken since:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20L%20(dbg)/builds/15895

and:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/15834

Log (from https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/11479/steps/SystemWebViewShellLayoutTest/logs/stdio):

C  118.088s Main  [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces:
C  118.088s Main  junit.framework.ComparisonFailure: Missing webview interfaces found expected:<[]> but was:<[interface PushSubscriptionOptions
C  118.088s Main  ]>
C  118.088s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:201)
C  118.088s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  118.088s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  118.088s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  118.088s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
C  118.088s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  118.088s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  118.088s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  118.088s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
C  118.088s Main  ********************************************************************************


Suspected CL:
https://codereview.chromium.org/2133673002
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd11513c44ebc8ed0d5da23b9a1b96e17050deea

commit dd11513c44ebc8ed0d5da23b9a1b96e17050deea
Author: johnme <johnme@chromium.org>
Date: Mon Jul 18 11:38:34 2016

Mark PushSubscriptionOptions not in WebView

https://codereview.chromium.org/2133673002 added a new
PushSubscriptionOptions interface, but forgot to mark it as not exposed
in WebView (since the Push API is not supported there). Hence that patch
broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch
fixes that.

BUG= 626627 , 629049 
TBR=lizeb@chromium.org,timvolodine@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2159713002
Cr-Commit-Position: refs/heads/master@{#405976}

[modify] https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Comment 2 by lizeb@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment