Issue metadata
Sign in to add a comment
|
Regression: Weird overlapping of context menu is seen in overview mode |
||||||||||||||||||||||
Issue descriptionVersion: 54.0.2798.0/8601.0.0 (Official Build) dev-channel Gnawty, Wolf OS: Chrome What steps will reproduce the problem? (1) Open any 2 windows >> Click on switch tab icon >> Hit any letter[say "g"] from keyboard >> Now open context menu on text field and observe Expected: Context menu options should be visible. Actual: Instead context menu lies behind the search box and menu options are not visible. NOTE: 1.In attached screenshot undo option is seen behind the search box 2.Name of the tab is also seen overlapped with context menu. This is a regression issue as context menu is visible in 52.0.2743.41/8350.31.0 beta channel daisy. @varkha: Please confirm the behavior.
,
Jul 18 2016
Is Expected_contextmenu.png screenshot from 52.0.2743.41/8350.31.0 beta channel daisy? Knowing that would help do a right fix for this since even there the context menu is behind the search, just the search used to be translucent.
,
Jul 18 2016
,
Jul 18 2016
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aef838caffce4c0c9701c0f907ce826b30b7907 commit 4aef838caffce4c0c9701c0f907ce826b30b7907 Author: varkha <varkha@chromium.org> Date: Mon Jul 18 18:16:27 2016 [ash-md] Fixes z-order to get context menus above overview items Changes the parent of search widget labels and close buttons in overview mode to be kShellWindowId_StatusContainer which is still above all windows but below menus and screen overlays. BUG= 629039 Review-Url: https://codereview.chromium.org/2154323002 Cr-Commit-Position: refs/heads/master@{#406040} [modify] https://crrev.com/4aef838caffce4c0c9701c0f907ce826b30b7907/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/4aef838caffce4c0c9701c0f907ce826b30b7907/ash/common/wm/overview/window_selector_item.cc
,
Jul 18 2016
,
Jul 22 2016
Would be good to merge this in M-53.
,
Jul 22 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 26 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6874ad6b61e061c17208cd7898ed07b7a56acbde commit 6874ad6b61e061c17208cd7898ed07b7a56acbde Author: Valery Arkhangorodsky <varkha@chromium.org> Date: Tue Jul 26 19:26:52 2016 [ash-md] Fixes z-order to get context menus above overview items Changes the parent of search widget labels and close buttons in overview mode to be kShellWindowId_StatusContainer which is still above all windows but below menus and screen overlays. BUG= 629039 Review-Url: https://codereview.chromium.org/2154323002 Cr-Commit-Position: refs/heads/master@{#406040} (cherry picked from commit 4aef838caffce4c0c9701c0f907ce826b30b7907) Review URL: https://codereview.chromium.org/2178353006 . Cr-Commit-Position: refs/branch-heads/2785@{#361} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/6874ad6b61e061c17208cd7898ed07b7a56acbde/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/6874ad6b61e061c17208cd7898ed07b7a56acbde/ash/common/wm/overview/window_selector_item.cc
,
Aug 12 2016
Chrome Os 54.0.2826.0/8697.0.0 samus |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Jul 18 2016