WebKit Android (Nexus4) broken (SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode) |
||
Issue descriptionWebKit Android (Nexus4) is broken since https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/50443 Broken tests: SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom Suspected CL: https://codereview.chromium.org/2151323004
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f33d0154201310ea6eeb515da696d2daab06791f commit f33d0154201310ea6eeb515da696d2daab06791f Author: lizeb <lizeb@chromium.org> Date: Mon Jul 18 11:41:12 2016 Revert of Calculate correct cull rect for SVG inline text boxes. (patchset #4 id:60001 of https://codereview.chromium.org/2151323004/ ) Reason for revert: Broke WebKit Android (Nexus4). BUG= 629023 , 627233 Original issue's description: > Calculate correct cull rect for SVG inline text boxes. > > Cull rects were larger than needed when text was selected. > > Identified while investigating test failure of: > > svg/text/text-selection-align-06-b.svg > > as part of http://crrev.com/2073563002 for crbug.com/616600 , though > fixing these did not actually fix any issues for that patch or bug. > > Reland of http://crrev.com/2137753002 with updated test to > approximate expected rects to allow for minor font metrics differences > across platforms. Notably, previous patch failed on Android Nexus 4 > due to 1 - 2 pixel deltas. > > BUG= 627233 > TBR=pdr > > Committed: https://crrev.com/344d1d48097756a754766c75b9c49c756f85d20e > Cr-Commit-Position: refs/heads/master@{#405920} TBR=pdr@google.com,wkorman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2161573002 Cr-Commit-Position: refs/heads/master@{#405977} [modify] https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f/third_party/WebKit/Source/core/editing/DOMSelection.h [modify] https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp [delete] https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp
,
Jul 18 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by lizeb@chromium.org
, Jul 18 2016