New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629023 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebKit Android (Nexus4) broken (SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode)

Project Member Reported by lizeb@chromium.org, Jul 18 2016

Issue description

WebKit Android (Nexus4) is broken since https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/50443

Broken tests:
SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode
SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom

Suspected CL:
https://codereview.chromium.org/2151323004
 

Comment 1 by lizeb@chromium.org, Jul 18 2016

Logs:

C  107.694s Main  ********************************************************************************
C  107.694s Main  Detailed Logs
C  107.694s Main  ********************************************************************************
C  107.698s Main  [FAIL] SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode:
C  107.698s Main  [ RUN      ] SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode
C  107.698s Main  [INFO:SkFontMgr_android_parser.cpp(608)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened
C  107.698s Main  
C  107.698s Main  [INFO:SkFontMgr_android_parser.cpp(608)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened
C  107.698s Main  
C  107.698s Main  ../../third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp:86: Failure
C  107.698s Main  Value of: outerRect.contains(actualRect) && !innerRect.contains(actualRect)
C  107.698s Main    Actual: false
C  107.698s Main  Expected: true
C  107.698s Main  Cull rect not approximately equal [expected=(50,3 15x33), actual=(50,2 15x35)].
C  107.698s Main  ../../third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp:86: Failure
C  107.698s Main  Value of: outerRect.contains(actualRect) && !innerRect.contains(actualRect)
C  107.698s Main    Actual: false
C  107.698s Main  Expected: true
C  107.698s Main  Cull rect not approximately equal [expected=(50,3 15x33), actual=(50,2 15x35)].
C  107.698s Main  [  FAILED  ] SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode (48 ms)
C  107.698s Main  [FAIL] SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom:
C  107.698s Main  [ RUN      ] SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom
C  107.698s Main  [INFO:SkFontMgr_android_parser.cpp(608)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened
C  107.698s Main  
C  107.698s Main  [INFO:SkFontMgr_android_parser.cpp(608)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened
C  107.698s Main  
C  107.699s Main  ../../third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp:86: Failure
C  107.699s Main  Value of: outerRect.contains(actualRect) && !innerRect.contains(actualRect)
C  107.699s Main    Actual: false
C  107.699s Main  Expected: true
C  107.699s Main  Cull rect not approximately equal [expected=(33,30 34x15), actual=(32,30 36x15)].
C  107.699s Main  ../../third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp:86: Failure
C  107.699s Main  Value of: outerRect.contains(actualRect) && !innerRect.contains(actualRect)
C  107.699s Main    Actual: false
C  107.699s Main  Expected: true
C  107.699s Main  Cull rect not approximately equal [expected=(33,30 34x16), actual=(32,30 36x16)].
C  107.699s Main  [  FAILED  ] SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom (45 ms)
C  107.699s Main  ********************************************************************************
C  107.699s Main  Summary
C  107.699s Main  ********************************************************************************
C  107.706s Main  [==========] 3655 tests ran.
C  107.706s Main  [  PASSED  ] 3653 tests.
C  107.706s Main  [  FAILED  ] 2 tests, listed below:
C  107.706s Main  [  FAILED  ] SVGInlineTextBoxPainterTest.TextCullRect_DefaultWritingMode
C  107.706s Main  [  FAILED  ] SVGInlineTextBoxPainterTest.TextCullRect_WritingModeTopToBottom
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33d0154201310ea6eeb515da696d2daab06791f

commit f33d0154201310ea6eeb515da696d2daab06791f
Author: lizeb <lizeb@chromium.org>
Date: Mon Jul 18 11:41:12 2016

Revert of Calculate correct cull rect for SVG inline text boxes. (patchset #4 id:60001 of https://codereview.chromium.org/2151323004/ )

Reason for revert:
Broke WebKit Android (Nexus4).

BUG= 629023 , 627233 

Original issue's description:
> Calculate correct cull rect for SVG inline text boxes.
>
> Cull rects were larger than needed when text was selected.
>
> Identified while investigating test failure of:
>
> svg/text/text-selection-align-06-b.svg
>
> as part of http://crrev.com/2073563002 for  crbug.com/616600 , though
> fixing these did not actually fix any issues for that patch or bug.
>
> Reland of http://crrev.com/2137753002 with updated test to
> approximate expected rects to allow for minor font metrics differences
> across platforms. Notably, previous patch failed on Android Nexus 4
> due to 1 - 2 pixel deltas.
>
> BUG= 627233 
> TBR=pdr
>
> Committed: https://crrev.com/344d1d48097756a754766c75b9c49c756f85d20e
> Cr-Commit-Position: refs/heads/master@{#405920}

TBR=pdr@google.com,wkorman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2161573002
Cr-Commit-Position: refs/heads/master@{#405977}

[modify] https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp
[delete] https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp

Comment 3 by lizeb@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)

Sign in to add a comment