New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629019 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Localization is not applied for 'Settings' text on 'You're now signed in to chrome' overlay.

Reported by dchau...@etouch.net, Jul 18 2016

Issue description

Chrome Version: 54.0.2799.0 (Official Build)8acb9d5f2f71c3df8e64b13ee321a9d194e89785-refs/heads/master@{#405947} 32/64-bit.
OS: Windows(7,8,10).

What steps will reproduce the problem?
1. Launch chrome, change browser language to 'Hindi' from chrome://settings/addLanguage and restart the chrome.
2. Sign in to chrome with valid credentials such that 'अब आपने Chrome में प्रवेश कर लिया है' overlay appears and observe.

Localization is not applied for 'Settings' text.
Localization should apply for 'Settings' text.

This is a regression issue, broken in M-50 series, below is manual bisect info.

Good build: 50.0.2632.0 
Bad build: 50.0.2633.3

Unable to Sign in to chromium builds hence won't be able to provide narrow bisect info.
Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/50.0.2632.0..50.0.2633.0?pretty=fuller&n=10000

Suspecting: r371907 ?

@anthonyvd: Kindly help to reassign, if your changes are not related to this issue.

Note: This issue is not seen on 'Mac' and 'Linux' OS.

Kindly review the attached screen-cast for reference.
 
Localization Screenshot.png
89.9 KB View Download
Actual behavior.mp4
848 KB View Download
Expected_behavior.mp4
901 KB View Download
Cc: anthonyvd@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
I think this might be a hiccup in the localization that was done on that string. I'll mark this as Untriaged so localization folks can pick it up. Please reassign to me if this requires code or string changes.
Labels: Needs-Feedback
dchaubey@ Are you still able to reproduce this issue.

Comment 3 by dchau...@etouch.net, Aug 10 2016

Labels: -Needs-Feedback
With response to comment#2: Retested the above issue on Windows-10 machine using Canary chrome version 54.0.2824.0 and beta chrome version 53.0.2785.57. It's still reproducible i.e. localization is not applied for 'Settings' text. 
Labels: Needs-Bisect
[Bulk Edit]- Assigning to In house-HYD Team and apply label - hasbisect-per-revison

If the issue still persist, try bisecting again with per-revision bisect script.
Labels: -hasbisect -M-54 -Needs-Bisect hasbisect-per-revision M-55
Ran using hasbisect-per-revision and got the below CL,
You are probably looking for a change made after 371905 (known good), but no later than 371909 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
 https://chromium.googlesource.com/chromium/src/+log/583be684fbad6f0c013ebe7e7b186c589386a926..605adccc5336fbc83fb41fc6516c0e64eb3a0f79

Unable to find the exact culprit using new CL.
Could some one please look into the issue and update.
Thank You.

Comment 6 by ananthak@google.com, Oct 18 2016

Labels: -hasbisect-per-revision
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 19 2016

Cc: ew...@chromium.org bzanotti@chromium.org msarda@chromium.org
Status: Available (was: Untriaged)
--Chrome Identity automated triaging--

This bug is Untriaged and has gone for two weeks without any activity, so it is being moved to Available. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -bzanotti@chromium.org

Comment 9 by ew...@chromium.org, May 12 2017

Status: Fixed (was: Available)
These strings were changed in M59 and I believe they've already been properly translated.

Sign in to add a comment