New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629013 link

Starred by 1 user
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Jul 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Make changing variation parameters in unit-tests simpler.

Project Member Reported by jkrcal@chromium.org, Jul 18 2016 
Currently, one has to call several function at various times in an unit test to get experiment variation parameters changed.

This should be simpler.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86e3d75af3140dce0826f797da9fbadb5bf952bd

commit 86e3d75af3140dce0826f797da9fbadb5bf952bd
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Jul 18 15:09:31 2016

Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG= 629013 

Review-Url: https://codereview.chromium.org/2145963002
Cr-Commit-Position: refs/heads/master@{#405992}

[modify] https://crrev.com/86e3d75af3140dce0826f797da9fbadb5bf952bd/components/variations/variations_associated_data.cc
[modify] https://crrev.com/86e3d75af3140dce0826f797da9fbadb5bf952bd/components/variations/variations_associated_data.h

Comment 2 by jkrcal@chromium.org, Jul 22 2016

Status: Fixed (was: Started)
►

Sign in to add a comment