Issue metadata
Sign in to add a comment
|
Regression: G+ logo is not seen properly on print preview page of 'plus.google.com'.
Reported by
rk...@etouch.net,
Jul 18 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2799.0 Revision 8acb9d5f2f71c3df8e64b13ee321a9d194e89785-refs/heads/master@{#405947}(32/64 bit) OS: Windows(10) What steps will reproduce the problem? (1) Launch chrome, navigate to https://plus.google.com/explore (2) Click on 'Share' icon of any image and give Print command by using ctrl+P (3) Observe the G+ logo on preview page. What is the expected result? G+ logo is not seen properly on preview page i.e. it looks like shrink. What happens instead? G+ logo should seen properly on preview page. This is a regression issue, broken in 'M-53', below is bisect info: Good Build: 53.0.2748.0 Bad Build: 53.0.2750.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/59d51f9a4cea0fd3d0c27eaf069442b9f556ea9a..d1b22fc961b1a2677c32f61a2a5640850b66adb9?pretty=fuller&n=100 Suspecting: r396308 ? @thestig: Please help me reassign this issue, if your change is not cause for it. Note: Issue is not seen on windows(7,8), Mac and Linux OS.
,
Jul 21 2016
thestig@: Could you please take a look at this. Adjusting the milestone as this is broken in M-53.
,
Jul 21 2016
Also maybe related, the change to enable material design on Windows, although I don't really see a direct link. https://chromium.googlesource.com/chromium/src/+/2676e97c1a42b7898fbc09176ab94b59bf1c421d Note we have even worse problems in m54. When I Ctrl-P the corresponding content when the share dialog is open I get empty pages or partial pages without the G+ share icon at all.
,
Jul 21 2016
Looking at the full changelist, these might also be the cause: https://chromium.googlesource.com/chromium/src/+/a172dfeb06603ec2417085f20d39fca2bc01d5be A Skia roll with: 2016-05-26 halcanary SkPDF/SkColorSpace: use writeToICC
,
Jul 25 2016
a) If this only happens on Windows 10, then I can't help track this down as I don't have a Windows 10 machine handy. b) This is not r396308. c) Probably not r396304 either. Are we sure the narrow bisect is correct? d) This could be the SkPDF change mentioned in comment 4. +halcanary
,
Jul 26 2016
,
Jul 28 2016
The G+ image is a background. Printing does not print backgrounds by default (there is actually an option in print to show the backgrounds, if desired). Therefore, this is working as intended.
,
Jul 28 2016
It also appears that G+ have modified their page recently, making this bug reproducible. In addition, the cause of the problems in comment #3, where we're missing most of the content in printing, is due to G+ putting a filter over the entire background when the share links are displayed.
,
Jul 28 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Jul 18 2016