New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629011 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Android Tests (dbg) broken (PaymentRequestNoShippingTest)

Project Member Reported by lizeb@chromium.org, Jul 18 2016

Issue description

Comment 1 by lizeb@chromium.org, Jul 18 2016

Cc: rouslan@chromium.org
Labels: -Pri-3 OS-Android Pri-1

Comment 2 by lizeb@chromium.org, Jul 18 2016

Cc: dfalcant...@chromium.org
Maybe it's https://codereview.chromium.org/2135573004

Comment 3 by lizeb@chromium.org, Jul 18 2016

It's actually https://codereview.chromium.org/2116583002

See the error:

C 1136.384s Main  Caused by: java.lang.AssertionError
C 1136.384s Main  	at org.chromium.chrome.browser.payments.ui.EditorFieldModel.createDropdown(EditorFieldModel.java:180)
C 1136.384s Main  	at org.chromium.chrome.browser.payments.CardEditor.addLocalCardInputs(CardEditor.java:363)
C 1136.384s Main  	at org.chromium.chrome.browser.payments.CardEditor.edit(CardEditor.java:264)
C 1136.385s Main  	at org.chromium.chrome.browser.payments.PaymentRequestImpl.editCard(PaymentRequestImpl.java:744)
C 1136.385s Main  	at org.chromium.chrome.browser.payments.PaymentRequestImpl.onSectionAddOption(PaymentRequestImpl.java:697)
C 1136.385s Main  	at org.chromium.chrome.browser.payments.ui.PaymentRequestUI.onAddPaymentOption(PaymentRequestUI.java:612)
C 1136.385s Main  	at org.chromium.chrome.browser.payments.ui.PaymentRequestSection$OptionSection.onClick(PaymentRequestSection.java:764)
C 1136.385s Main  	at android.view.View.performClick(View.java:4438)
C 1136.385s Main  	at org.chromium.chrome.browser.payments.PaymentRequestTestBase$5.run(PaymentRequestTestBase.java:171)
C 1136.385s Main  	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
C 1136.385s Main  	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
C 1136.385s Main  	at android.os.Handler.handleCallback(Handler.java:733)
C 1136.385s Main  	at android.os.Handler.dispatchMessage(Handler.java:95)
C 1136.385s Main  	at android.os.Looper.loop(Looper.java:136)
C 1136.385s Main  	at android.app.ActivityThread.main(ActivityThread.java:5001)
C 1136.385s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C 1136.385s Main  	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
C 1136.385s Main  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
C 1136.385s Main  	at dalvik.system.NativeStart.main(Native Method

Caused by (CardEditor.java:361)

        // Expiration year dropdown is side-by-side with the expiration year dropdown. The dropdown
        // should include the card's expiration year, so it's not cached.
        mYearField = EditorFieldModel.createDropdown(
                null /* label */, buildYearDropdownKeyValues(calendar, card.getYear()));


triggering (EditorFieldModel.java:178):

    public static EditorFieldModel createDropdown(
            CharSequence label, List<DropdownKeyValue> dropdownKeyValues) {
        assert label != null;

Since the assert was added in the CL above, the fix is not obvious. Reverting the CL.

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/097480da90d9a2b752b603ab3e1d7daa198af65f

commit 097480da90d9a2b752b603ab3e1d7daa198af65f
Author: lizeb <lizeb@chromium.org>
Date: Mon Jul 18 10:14:29 2016

Revert of Credit card editor for PaymentRequest UI. (patchset #5 id:490001 of https://codereview.chromium.org/2116583002/ )

Reason for revert:
Broke Android Tests (dbg).

BUG= 629011 , 624924 

Original issue's description:
> Credit card editor for PaymentRequest UI.
>
> When user taps on an incomplete autofill credit card or [+ ADD CARD]
> button, the card editor launches.
>
> For server cards, the editor shows uneditable card information and lets
> the user set the billing address.
>
> For local cards, the editor shows the following fields.
>
> 1) A list of icons for supported card types.
>
> 2) The card number input with Luhn validation and formatting. Required
>    field.
>
> 3) The name on card input. Required field.
>
> 4) The month and year dropdowns. January of this year by default for new
>    cards.
>
> 5) The billing address dropdown with only complete addresses on disk and
>    an option to add a new address. Required field.
>
> 6) A checkbox for saving the new card on disk. Checked by default,
>    so it behaves similar to autofill settings.
>
> BUG= 624924 
>
> Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
> Cr-Commit-Position: refs/heads/master@{#405876}

TBR=mathp@chromium.org,dfalcantara@chromium.org,estade@chromium.org,rouslan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2158783002
Cr-Commit-Position: refs/heads/master@{#405971}

[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-hdpi/pr_dinersclub.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-hdpi/pr_jcb.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-hdpi/pr_unionpay.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-mdpi/pr_dinersclub.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-mdpi/pr_jcb.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-mdpi/pr_unionpay.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xhdpi/pr_dinersclub.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xhdpi/pr_jcb.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xhdpi/pr_unionpay.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxhdpi/pr_dinersclub.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxhdpi/pr_jcb.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxhdpi/pr_unionpay.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxxhdpi/pr_dinersclub.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxxhdpi/pr_jcb.png
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxxhdpi/pr_unionpay.png
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/layout/payment_request_editor_icons.xml
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/layout/payment_request_editor_label.xml
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/res/values/ids.xml
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Validatable.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
[delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java_sources.gni
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/browser/android/resource_id.h
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/test/data/android/payments/no_shipping.js
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/autofill/core/browser/payments/full_card_request.cc
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/autofill/core/browser/payments/full_card_request.h
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/autofill_strings.grdp
[modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/resources/autofill_scaled_resources.grdp

Comment 5 by lizeb@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)

Sign in to add a comment