New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628992 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in SuperBlitter::blitH

Project Member Reported by ClusterFuzz, Jul 18 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5402857453125632

Fuzzer: afl_skia_path_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 2
Crash Address: 0x603000016030
Crash State:
  SuperBlitter::blitH
  sk_fill_path
  SkScan::AntiFillPath
  
Recommended Security Severity: Medium


Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95gWINcmvTgBfPUTn8Dc7dcGWymS9EmPiKH4uzPItA91o47uR1Aujt1bHGcnxG-gyczRSlSfvsN3G3RnygxbKmVYjJCoHT6vphmFtOnImb-cBgzIm4Hd2HXOUo_p-UYW0bc4Rwr6kyZAMqQhtVhvkavS9K6zg?testcase_id=5402857453125632


Additional requirements: Requires Gestures

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, Jul 18 2016

Cc: metzman@google.com
Components: Internals>Skia
Labels: -Stability-Libfuzzer Pri-1
Owner: reed@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 18 2016

Status: Assigned (was: Available)

Comment 3 by ta...@google.com, Jul 18 2016

Labels: Security_Impact-None

Comment 4 by aarya@google.com, Jul 18 2016

Labels: -Security_Impact-None Security_Impact-Head
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 19 2016

Labels: M-53
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 19 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Jul 19 2016

M53 beta launch is next week.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix before 6:00 PM PST, Friday (07/22/16). Thank you.
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 21 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 21 2016

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-Head ReleaseBlock-Beta
I'm afraid sheriffbot's label changes were a hiccup - this is still a blocker for Friday's M53. 

Project Member

Comment 11 by sheriffbot@chromium.org, Jul 22 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 22 2016

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-Head ReleaseBlock-Beta
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 23 2016

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 15 by reed@chromium.org, Jul 25 2016

Cc: reed@google.com
Is this still a problem? I can no longer reproduce it locally.

I request a retry. Here is the log:

[2016-07-25 17:50:19] reed@google.com: Redo task(s): progression
[2016-07-25 11:02:10] clusterfuzz-linux-0086: Progression task started: r407419.
[2016-07-25 11:02:31] clusterfuzz-linux-0086: Progression task in-progress: Testing r405946:r407419.
[2016-07-25 11:07:18] clusterfuzz-linux-0086: Progression task errored out: Known crash revision 405946 did not crash.
[2016-07-25 11:07:18] clusterfuzz-linux-0086: Progression task errored out: Test case appears to be flaky.
[2016-07-25 11:08:37] clusterfuzz-linux-0335: Blame task started.
[2016-07-25 11:08:49] clusterfuzz-linux-0335: Blame task finished.

Comment 16 by reed@chromium.org, Jul 25 2016

Cc: hcm@chromium.org
Project Member

Comment 17 by ClusterFuzz, Jul 26 2016

ClusterFuzz has detected this issue as fixed in range 406564:406863.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5402857453125632

Fuzzer: afl_skia_path_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 2
Crash Address: 0x603000006b20
Crash State:
  SuperBlitter::blitH
  sk_fill_path
  SkScan::AntiFillPath
  
Recommended Security Severity: Medium

Fixed: https://cluster-fuzz.appspot.com/revisions?job=afl_chrome_asan&range=406564:406863

Minimized Testcase (0.09 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94_rXA6_0bXIeYqLO5b_jwP_qY65TQzGcEo9iwhEYE4UtCSX22xfAfT608k6o0cdw9XIq-tPZQsGlaBnd-EQOWMkWWgoBapOANColo3mQPfMU5lxzFa7oSR1RhJM7KP4c3CEBBMMzkxRP4IQ2Ou38uZVw4TIA?testcase_id=5402857453125632

Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 18 by ClusterFuzz, Jul 26 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 19 by sheriffbot@chromium.org, Jul 26 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 21 by sheriffbot@chromium.org, Jul 29 2016

Labels: Merge-Request-53

Comment 22 by dimu@chromium.org, Jul 30 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 23 Deleted

Please try to merge your change to M53 branch 2785 asap so we can take it for this week beta release on Wednesday. Thank you very much.

Comment 25 by reed@google.com, Aug 2 2016

path.moveTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000));  // 0, 0

path.lineTo(SkBits2Float(0xcdafcdcd), SkBits2Float(0x41423fcd));  // -3.68688e+08f, 12.1406f

path.conicTo(SkBits2Float(0x414140ed), SkBits2Float(0x41414141), SkBits2Float(0x41414141), SkBits2Float(0x41264141), SkBits2Float(0x0000e1c8));  // 12.0784f, 12.0784f, 12.0784f, 10.3909f, 8.09951e-41f

path.cubicTo(SkBits2Float(0xcdcdcd00), SkBits2Float(0xcdcdcdcd), SkBits2Float(0xcdcdcdcd), SkBits2Float(0xcdcdcdcd), SkBits2Float(0x423fcdcd), SkBits2Float(0x40f79341));  // -4.31596e+08f, -4.31602e+08f, -4.31602e+08f, -4.31602e+08f, 47.951f, 7.73673f

path.lineTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000));  // 0, 0
path.close();

This seems to trigger an assert in debug-build...
We're cutting M53 Beta RC today for release tomorrow. Please try to merge your change to M53 branch 2785 before 5:30 PM PT today so we can take it for this week beta. Thank you.

Comment 27 by hcm@chromium.org, Aug 2 2016

Labels: -Hotlist-Merge-Approved -Merge-Approved-53
I'm removing the 53 merge labels, sheriffbot put them on erroneously as something was detected as fixed, but there is no target CL.  Nothing to merge here (yet).
Project Member

Comment 28 by sheriffbot@chromium.org, Nov 1 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment