New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628979 link

Starred by 43 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Pressing ESC in Find (CMD+F) while in Fullscreen exits Fullscreen instead of closing Find

Reported by mrdai...@gmail.com, Jul 18 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce the problem:
1. Enter Full screen by green button or Ctrl+Cmd+F
2. Open any url
3. Open Search on page by Cmd+F
4. Search anything on page
5. Press escape

What is the expected behavior?
Search pane should disappear

What went wrong?
Search pane still visible, but window not in full-screen now

Did this work before? No 

Chrome version: 51.0.2704.103  Channel: stable
OS Version: OS X 10.12.0
Flash Version: Shockwave Flash 22.0 r0

macOS Sierra public beta
 

Comment 1 by tczz...@gmail.com, Jul 18 2016

Same issue here.
And in full-screen mode some pages cannot do search.
UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2799.0 Safari/537.36

Comment 2 by rsesek@chromium.org, Jul 18 2016

Cc: spqc...@chromium.org
Components: -UI UI>Browser>FullScreen UI>Browser>FindInPage
Labels: Hotlist-Sierra
Cannot repro on 10.11.5.
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Cannot repro on 10.11.6, but mark@ reproed on Sierra. Assigning to spqchan@ for fullscreen stuff :)

Comment 4 by mrdai...@gmail.com, Aug 11 2016

I've just found that it is not a Chrome's bug, it's Sierra's bug, because just got the same issue in iTunes.
 Issue 645644  has been merged into this issue.

Comment 6 by rsesek@chromium.org, Sep 21 2016

 Issue 648933  has been merged into this issue.

Comment 7 by rsesek@chromium.org, Sep 21 2016

Summary: Pressing ESC in Find (CMD+F) while in Fullscreen exits Fullscreen instead of closing Find (was: Full-screen mode breaks by esc in search)

Comment 8 by meh...@chromium.org, Sep 27 2016

 Issue 650599  has been merged into this issue.

Comment 9 by dorme...@gmail.com, Sep 28 2016

Can repro on 10.12 release.
Chrome leaves fullscreen when hitting ESC with the Search panel focused.
However, Chrome does not leave fullscreen when the panel is not focused.
 Issue 651209  has been merged into this issue.
 Issue 651418  has been merged into this issue.
Cc: hdodda@chromium.org
 Issue 652048  has been merged into this issue.
Labels: -Pri-2 M-55 Pri-1
Status: Started (was: Assigned)
 Issue 653232  has been merged into this issue.

Comment 17 by a...@nanlabs.net, Oct 7 2016

Seems to be fixed in  55.0.2882.0 dev (64-bit)
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/795ed3707fefc9d39d836545d860f216df620c66

commit 795ed3707fefc9d39d836545d860f216df620c66
Author: spqchan <spqchan@chromium.org>
Date: Mon Oct 10 23:20:47 2016

[Mac] Fix an ESC key issue with the find bar on Sierra

Prevent the window from handling the ESC key when the find bar text is
focused on Sierra.

BUG= 628979 

Review-Url: https://codereview.chromium.org/2398303002
Cr-Commit-Position: refs/heads/master@{#424279}

[modify] https://crrev.com/795ed3707fefc9d39d836545d860f216df620c66/chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm
[modify] https://crrev.com/795ed3707fefc9d39d836545d860f216df620c66/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Status: Fixed (was: Started)
I'd consider a merge to M55/M54 as well after this bakes.
Status: Started (was: Fixed)
Good point. I'll leave this open
 Issue 654504  has been merged into this issue.
 Issue 654533  has been merged into this issue.
Labels: Merge-Request-55

Comment 25 by dimu@chromium.org, Oct 13 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1

commit d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1
Author: spqchan <spqchan@chromium.org>
Date: Thu Oct 13 20:57:44 2016

[Mac] Fix an ESC key issue with the find bar on Sierra

Prevent the window from handling the ESC key when the find bar text is
focused on Sierra.

BUG= 628979 

Review-Url: https://codereview.chromium.org/2398303002
Cr-Commit-Position: refs/heads/master@{#424279}
(cherry picked from commit 795ed3707fefc9d39d836545d860f216df620c66)

Review URL: https://codereview.chromium.org/2419783003 .

Cr-Commit-Position: refs/branch-heads/2883@{#94}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1/chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm
[modify] https://crrev.com/d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Comment 27 by ratsu...@gmail.com, Oct 17 2016

Any chance for merging it into M54 since M55 still has about 2 months to arrive? 
Thanks
Labels: Merge-Request-54

Comment 29 by dimu@chromium.org, Oct 17 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
Cc: ranjitkan@chromium.org
Labels: TE-Verified-M55 TE-Verified-55.0.2883.18
Rechecked the issue on MAC 10.11.6 for chrome version 55.0.2883.18. Fix is working as intended. 

1) Installed chrome and launched it in full screen mode
2) Navigated to a website and searched for a string using Find It tool
3) Pressed Esc button and Find it window closed and Browser remained in full screen mode.

Adding TE-verified labels.
Labels: -TE-Verified-M55 -TE-Verified-55.0.2883.18 M-54
Thanks for the fix, we will verify in Mac 10.12 and update the thread.
Labels: -Merge-Review-54 Merge-Rejected-54
This is too close to the full stable launch of M54.
Missed the OS version while checking (comment#30)

Rechecked the issue on MAC 10.12 Sierra for chrome version 55.0.2883.20. Fix is working as intended. 

1) Installed chrome and launched it in full screen mode
2) Navigated to a website and searched for a string using Find It tool
3) Pressed Esc button and Find it window closed and Browser remained in full screen mode.

Thanks.!
 Issue 659974  has been merged into this issue.
Status: Fixed (was: Started)
Project Member

Comment 36 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1

commit d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1
Author: spqchan <spqchan@chromium.org>
Date: Thu Oct 13 20:57:44 2016

[Mac] Fix an ESC key issue with the find bar on Sierra

Prevent the window from handling the ESC key when the find bar text is
focused on Sierra.

BUG= 628979 

Review-Url: https://codereview.chromium.org/2398303002
Cr-Commit-Position: refs/heads/master@{#424279}
(cherry picked from commit 795ed3707fefc9d39d836545d860f216df620c66)

Review URL: https://codereview.chromium.org/2419783003 .

Cr-Commit-Position: refs/branch-heads/2883@{#94}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1/chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm
[modify] https://crrev.com/d9d9cc57897c2bbf7a1c96022403bb9e64bcd0a1/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

 Issue 660440  has been merged into this issue.
 Issue 661477  has been merged into this issue.

Comment 39 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
 Issue 662582  has been merged into this issue.
Issue 662665 has been merged into this issue.

Comment 42 by jamzs...@gmail.com, Nov 19 2016

I only recently noticed this behavior.  I went about a year without a MacBook and never noticed this on my old one, but on my new one this has started happening.  Judging by the other comments it looks like this is MacOS 10.12 related, as I am running 10.12.1.
 Issue 668559  has been merged into this issue.
 Issue 669010  has been merged into this issue.
Cc: jchuang@google.com
 Issue 671110  has been merged into this issue.

Comment 46 by d...@chromium.org, Dec 5 2016

Any chance of a fix for this getting rolled into a Stable patch? Speaking personally, I've fully switched over to Canary specifically because of this bug (which is maybe what Chromium wants, bwahaha). If my experiences have any reflection on our real world users, this is an annoying and noticeable pain point for them.
This was merged to M55/2883 in #36, which is currently being pushed to stable. So the fix should roll out shortly.

Comment 48 by d...@chromium.org, Dec 5 2016

Oh excellent :D
 Issue 671654  has been merged into this issue.
Cc: meh...@chromium.org
 Issue 672061  has been merged into this issue.

Sign in to add a comment