New issue
Advanced search Search tips

Issue 628972 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

File Manager Accessibility with CVox

Reported by nimerjaber1@gmail.com, Jul 18 2016

Issue description

Mode: force_next
Version: 54.0.2798.0
Reproduction Steps: 
1. Launch CVox Next
2. Launch File Manager.
3. Shift+tab to access pane with drive, add new services, and any other storage.
4. Up/down arrow to change location.
Expected: CVox would read the options presented.
Actual: Only reason I know these options exist is because I can use CVox+Right Arrow to access the options, although I don't appear to be able to activate any option with CVox+Space. Up/down arrow does not read the contents of this tree of items.

 
Labels: Phase3
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58

commit ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58
Author: dtseng <dtseng@chromium.org>
Date: Fri Aug 12 03:43:39 2016

Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things, tells Blink to  fire an active descendant change event when the aria-activedescendant id changes. This also causes ChromeVox to announce the tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with the HTMLElement via aria-label. Note that a client such as ChromeVox would not have any other way of knowing this label other than a heuristic like reading hte descendants of the tree item. In this case, that won't work because the tree items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items. Previously, we only dealt with entering tree tiems because we only placed range around a tree item via navigation. However, it's possible to focus tree items via active descendant or explicit page focus, so provide a rule for this case.

BUG= 628972 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2160303002
Cr-Commit-Position: refs/heads/master@{#411545}

[modify] https://crrev.com/ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58/ui/webui/resources/js/cr/ui/tree.js

Labels: files.app
This is great, thanks!!

Comment 5 by dtseng@chromium.org, Oct 25 2016

Status: fixed (was: Assigned)

Comment 6 by dtseng@chromium.org, Oct 26 2016

Cc: lpalmaro@chromium.org dtseng@chromium.org
 Issue 631889  has been merged into this issue.
Status: Verified (was: Fixed)
verified on 56.0.2903.0

Sign in to add a comment