Initial value for mask-repeat property should be no-repeat
Reported by
cjcool...@gmail.com,
Jul 18 2016
|
|||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0 Example URL: Steps to reproduce the problem: 1. Access any web page which has a CSS mask. 2. The initial value of webkit-mask-repeat should be no-repeat 3. What is the expected behavior? initial value for mask-repeat should be no-repeat per spec[1]. I [1] https://www.w3.org/TR/css-masking-1/#the-mask-repeat What went wrong? In current implementation, the default value is repeat instead of no-repeat. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? No Does this work in other browsers? No safari Chrome version: <Copy from: 'about:version'> Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 22.0 r0
,
Jul 19 2016
Sure, you may use this page: https://jsfiddle.net/v5skqjvh/3/ While "initial" is selected, only one star should be seen.
,
Jul 19 2016
Thank you for providing more feedback. Adding requester "kavvaru@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20 2016
Thanks for the response. Able to reproduce the issue on win8.1 chrome version 54.0.2802.0 and 51.0.2704.106 - On page load the default drop down option initial is selected with number of stars dispalying. On selecting "no-repeat" option in drop down single star is displayed Please find the screenshot This is a non regression issue existing since M30 builds to latest canary Firefox behaviour : No stars displayed IE Behaviour : Page not loaded Confirming the issue for further inputs on this
,
Jul 20 2016
Issue can be seen in Linux and mac as well.
,
Jul 21 2016
,
Jul 22 2016
Would like to work on this bug. Added a patch at https://codereview.chromium.org/2169343002/
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b76fc4469acf4c44336dd8d42d1e127c8823d08b commit b76fc4469acf4c44336dd8d42d1e127c8823d08b Author: ramya.v <ramya.v@samsung.com> Date: Mon Jul 25 09:14:04 2016 Initial value for mask-repeat property should be no-repeat Spec: https://www.w3.org/TR/css-masking-1/#the-mask-repeat BUG= 628968 Review-Url: https://codereview.chromium.org/2169343002 Cr-Commit-Position: refs/heads/master@{#407435} [modify] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/paint/masks/fieldset-mask-expected.png [modify] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/Source/core/style/FillLayer.h
,
Jul 25 2016
,
Sep 11 2016
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f16dca5938110c60ff99aafa2a6afab35cab21af commit f16dca5938110c60ff99aafa2a6afab35cab21af Author: mmoss <mmoss@chromium.org> Date: Tue Sep 13 23:31:32 2016 Revert of Initial value for mask-repeat property should be no-repeat (patchset #2 id:20001 of https://codereview.chromium.org/2169343002/ ) Reason for revert: This appears to be causing crbug.com/645000 Original issue's description: > Initial value for mask-repeat property should be no-repeat > > Spec: https://www.w3.org/TR/css-masking-1/#the-mask-repeat > > BUG= 628968 > > Committed: https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b > Cr-Commit-Position: refs/heads/master@{#407435} TBR=timloh@chromium.org,ramya.v@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 628968 Review-Url: https://codereview.chromium.org/2332373003 Cr-Commit-Position: refs/heads/master@{#418411} [modify] https://crrev.com/f16dca5938110c60ff99aafa2a6afab35cab21af/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/f16dca5938110c60ff99aafa2a6afab35cab21af/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/f16dca5938110c60ff99aafa2a6afab35cab21af/third_party/WebKit/LayoutTests/paint/masks/fieldset-mask-expected.png [modify] https://crrev.com/f16dca5938110c60ff99aafa2a6afab35cab21af/third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/f16dca5938110c60ff99aafa2a6afab35cab21af/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/f16dca5938110c60ff99aafa2a6afab35cab21af/third_party/WebKit/Source/core/style/FillLayer.h
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5 commit 52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5 Author: Di Mu <dimu@chromium.org> Date: Wed Sep 14 00:45:01 2016 Revert of Initial value for mask-repeat property should be no-repeat (patchset #2 id:20001 of https://codereview.chromium.org/2169343002/ ) Reason for revert: This appears to be causing crbug.com/645000 Original issue's description: > Initial value for mask-repeat property should be no-repeat > > Spec: https://www.w3.org/TR/css-masking-1/#the-mask-repeat > > BUG= 628968 > > Committed: https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b > Cr-Commit-Position: refs/heads/master@{#407435} TBR=timloh@chromium.org,ramya.v@samsung.com BUG= 628968 Review-Url: https://codereview.chromium.org/2332373003 Cr-Commit-Position: refs/heads/master@{#418411} (cherry picked from commit f16dca5938110c60ff99aafa2a6afab35cab21af) Review URL: https://codereview.chromium.org/2333373004 . Cr-Commit-Position: refs/branch-heads/2840@{#349} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/paint/masks/fieldset-mask-expected.png [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/Source/core/style/FillLayer.h
,
Oct 3 2016
,
Oct 3 2016
What's the status on this bug? Should the spec be changed if Blink feels its not web compatible enough to ship? Gecko has seen a few broken sites as well.
,
Oct 4 2016
,
Oct 5 2016
Marking Tab as owner to take a look at potential spec changes here.
,
Oct 5 2016
,
Oct 24 2016
Filed https://github.com/w3c/fxtf-drafts/issues/56 for the CSSWG. But we (and other browsers?) haven't shipped the mask APIs unprefixed yet. If the spec doesn't change, and we can't change -webkit-mask-repeat, then at least we can match the spec for the unprefixed mask-repeat, right?
,
Oct 25 2016
Yup, that sounds like the path to go down if the CSSWG issue doesn't yield anything.
,
Oct 25 2016
How do you propose to have different initial values for properties that alias each other? What conditions make you switch from one initial value to another?
,
Oct 25 2016
(Note that there are various possibilities, but all the ones I can think of are imperfect (but possibly good enough) emulation of the old behavior. For example, if enough of the real world usage of -webkit-mask-* is the shorthand -webkit-mask and not the longhands, then the shorthand could be made to imply a non-initial value of mask-repeat when mask-repeat is unspecified.)
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5 commit 52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5 Author: Di Mu <dimu@chromium.org> Date: Wed Sep 14 00:45:01 2016 Revert of Initial value for mask-repeat property should be no-repeat (patchset #2 id:20001 of https://codereview.chromium.org/2169343002/ ) Reason for revert: This appears to be causing crbug.com/645000 Original issue's description: > Initial value for mask-repeat property should be no-repeat > > Spec: https://www.w3.org/TR/css-masking-1/#the-mask-repeat > > BUG= 628968 > > Committed: https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b > Cr-Commit-Position: refs/heads/master@{#407435} TBR=timloh@chromium.org,ramya.v@samsung.com BUG= 628968 Review-Url: https://codereview.chromium.org/2332373003 Cr-Commit-Position: refs/heads/master@{#418411} (cherry picked from commit f16dca5938110c60ff99aafa2a6afab35cab21af) Review URL: https://codereview.chromium.org/2333373004 . Cr-Commit-Position: refs/branch-heads/2840@{#349} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/paint/masks/fieldset-mask-expected.png [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/52e65397c9b47f5cfb5ea25cdf2f8534ded3d7e5/third_party/WebKit/Source/core/style/FillLayer.h
,
Feb 8 2017
Given https://bugs.chromium.org/p/chromium/issues/detail?id=645000#c9, maybe we can consider re-landing the fix for this?
,
Feb 12 2017
,
Dec 6 2017
,
Jan 30 2018
,
Apr 1 2018
The spec appears to be changing to match our behavior (also relevant for bug 628967 ): https://github.com/w3c/fxtf-drafts/issues/111.
,
Apr 20 2018
Spec changed in https://github.com/w3c/fxtf-drafts/commit/bdb4c3155192a10a5205c5842fe063e15a887f42, not sure if there are existing testcases for this that should be upstreamed to WPT. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, Jul 19 2016