New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628932 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ARC++ Incorrect close animations on the Samus at 2560x1700

Project Member Reported by reve...@chromium.org, Jul 17 2016

Issue description

This is a result of the scale property set by ARC++ for this resolution being reset too early in the shell surface dtor.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 18 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14bc66f849fad108c4f33883f40988dc3041e3c3

commit 14bc66f849fad108c4f33883f40988dc3041e3c3
Author: reveman <reveman@chromium.org>
Date: Mon Jul 18 18:32:19 2016

exo: Close widget at the top of ShellSurface dtor.

Allows widget close animations to use the scale assigned
to shell surface at the time it is destroyed.

BUG= 628932 , b/29082277

Review-Url: https://codereview.chromium.org/2157863002
Cr-Commit-Position: refs/heads/master@{#406044}

[modify] https://crrev.com/14bc66f849fad108c4f33883f40988dc3041e3c3/components/exo/shell_surface.cc

Labels: M-53 Merge-Request-53
Status: Fixed (was: Untriaged)
This fix is limited components/exo and as a result only affects ARC++ ChromeOS devices.

Comment 4 by dimu@google.com, Jul 19 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64d82b080a790e656b64e533e474741d328e5207

commit 64d82b080a790e656b64e533e474741d328e5207
Author: David Reveman <reveman@chromium.org>
Date: Tue Jul 19 17:45:49 2016

exo: Close widget at the top of ShellSurface dtor.

Allows widget close animations to use the scale assigned
to shell surface at the time it is destroyed.

BUG= 628932 , b/29082277

Review-Url: https://codereview.chromium.org/2157863002
Cr-Commit-Position: refs/heads/master@{#406044}
(cherry picked from commit 14bc66f849fad108c4f33883f40988dc3041e3c3)

Review URL: https://codereview.chromium.org/2162963003 .

Cr-Commit-Position: refs/branch-heads/2785@{#220}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/64d82b080a790e656b64e533e474741d328e5207/components/exo/shell_surface.cc

Status: Verified (was: Fixed)
ChromeOS build 8530.96.0 / 53.0.2785.154

Sign in to add a comment