New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628929 link

Starred by 3 users
Status: Fixed
Owner:
█ j.iso...@samsung.com
Email to this user bounced
Closed: Aug 2016
Cc:
█ kbr@chromium.org
piman@chromium.org
zmo@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Fails to extract gpu driver_version and vendor from gl_version

Project Member Reported by j.iso...@samsung.com, Jul 17 2016 
Version: Chrome/54.0.2800.0
OS: Linux

CollectDriverInfoGL fails to extract driver_vendor and driver_version when gl_version is for example:

3.3 (Core Profile) Mesa 10.5.9

Comment 1 by j.iso...@samsung.com, Jul 17 2016 

I uploaded a fix for it: https://codereview.chromium.org/2153373002/
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd

commit e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Author: j.isorce <j.isorce@samsung.com>
Date: Tue Jul 26 15:22:24 2016

On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG= 628929 

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Review-Url: https://codereview.chromium.org/2153373002
Cr-Commit-Position: refs/heads/master@{#407804}

[modify] https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd/gpu/config/gpu_info_collector_linux.cc
[modify] https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd/gpu/config/gpu_info_collector_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cebbdfb442249d56a3567444ee71ce256863f35

commit 7cebbdfb442249d56a3567444ee71ce256863f35
Author: kbr <kbr@chromium.org>
Date: Wed Jul 27 18:37:04 2016

Revert of On Linux rework driver_version/vendor extraction from gl version (patchset #9 id:160001 of https://codereview.chromium.org/2153373002/ )

Reason for revert:
Still breaks tests on Linux Intel:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28New%20Intel%29/builds/2661

Original issue's description:
> On Linux rework driver_version/vendor extraction from gl version
>
> Previously it could not extract them from the gl version
> "3.3 (Core Profile) Mesa 10.5.9" because of the presence
> of '(Core Profile)'.
>
> BUG= 628929 
>
> R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
>
> Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
> Cr-Commit-Position: refs/heads/master@{#407804}

TBR=piman@chromium.org,zmo@chromium.org,patyag0814@gmail.com,cwallez@chromium.org,j.isorce@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 628929 

Review-Url: https://codereview.chromium.org/2182993004
Cr-Commit-Position: refs/heads/master@{#408198}

[modify] https://crrev.com/7cebbdfb442249d56a3567444ee71ce256863f35/gpu/config/gpu_info_collector_linux.cc
[modify] https://crrev.com/7cebbdfb442249d56a3567444ee71ce256863f35/gpu/config/gpu_info_collector_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65e8f9730d970724d533a27b96d7c6388c84358

commit f65e8f9730d970724d533a27b96d7c6388c84358
Author: j.isorce <j.isorce@samsung.com>
Date: Fri Jul 29 08:15:10 2016

On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG= 628929 

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Review-Url: https://codereview.chromium.org/2153373002
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}

[modify] https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358/gpu/config/gpu_info_collector_linux.cc
[modify] https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358/gpu/config/gpu_info_collector_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc

commit f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc
Author: cwallez <cwallez@chromium.org>
Date: Mon Aug 01 20:49:46 2016

Revert of On Linux rework driver_version/vendor extraction from gl version (patchset #11 id:200001 of https://codereview.chromium.org/2153373002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=633286

Original issue's description:
> On Linux rework driver_version/vendor extraction from gl version
>
> Previously it could not extract them from the gl version
> "3.3 (Core Profile) Mesa 10.5.9" because of the presence
> of '(Core Profile)'.
>
> BUG= 628929 
>
> R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
>
> Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
> Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
> Cr-Original-Commit-Position: refs/heads/master@{#407804}
> Cr-Commit-Position: refs/heads/master@{#408604}

TBR=kbr@chromium.org,piman@chromium.org,zmo@chromium.org,patyag0814@gmail.com,j.isorce@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 628929 

Review-Url: https://codereview.chromium.org/2198243002
Cr-Commit-Position: refs/heads/master@{#409049}

[modify] https://crrev.com/f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc/gpu/config/gpu_info_collector_linux.cc
[modify] https://crrev.com/f1c7fb66c2edd6be58a8bb5e1b67d679e2b44dfc/gpu/config/gpu_info_collector_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84e4f0e4b82370e00bfc07cb05c489783b219bee

commit 84e4f0e4b82370e00bfc07cb05c489783b219bee
Author: j.isorce <j.isorce@samsung.com>
Date: Fri Aug 12 07:16:29 2016

On Linux rework driver_version/vendor extraction from gl version

Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.

BUG= 628929 

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*

Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
Review-Url: https://codereview.chromium.org/2153373002
Cr-Original-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Original-Commit-Position: refs/heads/master@{#408604}
Cr-Commit-Position: refs/heads/master@{#411568}

[modify] https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee/content/browser/browser_main_loop.cc
[modify] https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee/gpu/config/gpu_info_collector_linux.cc
[modify] https://crrev.com/84e4f0e4b82370e00bfc07cb05c489783b219bee/gpu/config/gpu_info_collector_unittest.cc

Comment 7 by j.iso...@samsung.com, Aug 16 2016 

I am waiting for all these bots https://build.chromium.org/p/chromium.gpu.fyi/builders/ to be green to mark this issue as fixed. But it seems that some webgl tests keep failing. But I do not think this is due the CL above.

Comment 8 by kbr@chromium.org, Aug 16 2016

Status: Fixed (was: Started)
I've checked the failures on the bots. The primary ones are the Linux Intel Release and Debug bots:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28New%20Intel%29
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28New%20Intel%29

I'm 99.99% sure the failures there are unrelated to your patch. Let's move this to Fixed. Thanks for your contribution.
►

Sign in to add a comment