New issue
Advanced search Search tips

Issue 628878 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jul 2016
Cc:
tbuck...@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

"Get help with Chrome" row is missing help center text (or is too tall)

Project Member Reported by michae...@chromium.org, Jul 16 2016 
"Get help with Chrome" in chrome://md-settings/help should have sub-text ("Open Chrome Help center") according to the mocks.

If we don't want the sub-text, we should remove the "two-line" class so it's teh proper height.

dpapad, do you recall why this was .two-line but didn't have secondary text? https://codereview.chromium.org/1981033003/diff/140001/chrome/browser/resources/settings/about_page/about_page.html

Comment 1 by dpa...@chromium.org, Jul 18 2016

Cc: bettes@chromium.org
I asked Alan about this at https://bugs.chromium.org/p/chromium/issues/detail?id=610529#c3, and the answer at https://bugs.chromium.org/p/chromium/issues/detail?id=610529#c4 implies that there should be no secondary text.

I'll send a CL to remove the "two-line" CSS class.

@bettes: Could you update the mocks to reflect the fact that not secondary text is desired?
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8c16c8de1f6e2df2ebc01c1a36b675ae6b0b2d3

commit b8c16c8de1f6e2df2ebc01c1a36b675ae6b0b2d3
Author: dpapad <dpapad@chromium.org>
Date: Mon Jul 18 21:04:08 2016

MD Settings: About page, remove unnecessary two-line CSS class.

BUG= 628878 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2156883003
Cr-Commit-Position: refs/heads/master@{#406090}

[modify] https://crrev.com/b8c16c8de1f6e2df2ebc01c1a36b675ae6b0b2d3/chrome/browser/resources/settings/about_page/about_page.html

Comment 3 by dpa...@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment