New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628870 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::IntRect::maxX

Project Member Reported by ClusterFuzz, Jul 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5916848453582848

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntRect::maxX
  blink::IntRect::intersect
  blink::CompositingInputsUpdater::updateRecursive
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027

Minimized Testcase (0.16 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94VWcKXqER5fRKbXIFvGNFn_S27U5cTxTB6xoM7TYCbdW6CR0VnDZOG1RmbU1ihjGhcg1mwDFAm7hBWyt0cOv8v6IqOJDbd7I7GBokqV1LaXtKzcuAhzuitcOsBtD-O8fjCmOFiXaSEKU5KNTv-OxRo1YPMfg?testcase_id=5916848453582848
<style>
@keyframes cfpulse1 { 0% { opacity: 0.4751;  } 
 100% { opacity: 0.619;  } }
* { animation-name: cfpulse95; motion-path: path("M 18446744073709551482 -45 V 1");


Filer: thestig

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: e...@chromium.org
Components: Blink
Project Member

Comment 2 by ClusterFuzz, Jul 16 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5648362934370304

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntRect::maxY
  blink::IntRect::intersect
  blink::CompositingInputsUpdater::updateRecursive
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027

Minimized Testcase (0.07 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97mPfESSEN2kjQlv0Rj5Gv4x3n5Q9P0Tj3xhPmLz0irwmuWLyYVJrdiqGQq9RcGQBRsf_CM9_7vsGXSRWhluRcrCpS1BYdOXn_mp93zWkl983fDiLGFwnEalTfq9VoB-kssmsQyFrgHeLeq-MqQJvp54Hz96g?testcase_id=5648362934370304
<dl style='motion-path: path("M -57 18446744073709551513 V 114"); '>


Additional requirements: Requires HTTP

Filer: thestig

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

Comment 3 by tkent@chromium.org, Jul 16 2016

Components: -Blink Blink>Paint
Status: Untriaged (was: Available)
eae@, Any update on this please.
Cc: -e...@chromium.org
Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)
Not eae@'s problem. I'll look into it.
Cc: tkonch...@chromium.org
This is indeed likely to be integer overflow, but it's not dangerous in any sense in that we correctly handle negative widths/heights in rects and negative positions. Odd things might happen, but it's not dangerous.

It can probably be fixed, but only at significant performance cost. I want to suppress this. How do I do that?
Project Member

Comment 7 by ClusterFuzz, Sep 29 2016

ClusterFuzz has detected this issue as fixed in range 414800:414808.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5916848453582848

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntRect::maxX
  blink::IntRect::intersect
  blink::CompositingInputsUpdater::updateRecursive
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=414800:414808

Minimized Testcase (0.16 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94VWcKXqER5fRKbXIFvGNFn_S27U5cTxTB6xoM7TYCbdW6CR0VnDZOG1RmbU1ihjGhcg1mwDFAm7hBWyt0cOv8v6IqOJDbd7I7GBokqV1LaXtKzcuAhzuitcOsBtD-O8fjCmOFiXaSEKU5KNTv-OxRo1YPMfg?testcase_id=5916848453582848
<style>
@keyframes cfpulse1 { 0% { opacity: 0.4751;  } 
 100% { opacity: 0.619;  } }
* { animation-name: cfpulse95; motion-path: path("M 18446744073709551482 -45 V 1");


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: Pri-2
Hi, I also got a integer overflow on blink::IntRect bug, what should be the strategy? Should I just suppress it? How do I do that? Thanks.

Comment 10 by pdr@chromium.org, Nov 1 2016

@Xidachen, I would recommend manually looking into it and determining if it is a security issue or not. If it is not, you can close the bug as wontfix. If it is, consider using saturated arithmetic.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by ClusterFuzz, Dec 22 2016

Status: WontFix (was: Assigned)
ClusterFuzz testcase 5648362934370304 is flaky and no longer reproduces, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment