New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628863 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

UniformBlock needs to have big enough data source

Project Member Reported by zmo@chromium.org, Jul 16 2016

Issue description

According to ES spec, if not, it's undefined behavior.

ES Spec 3.00.4, section 2.12.6, under "Uniform Buffer Object Bindings"

"If any active uniform block is not backed by a sufficiently large buffer object, the results of shader execution are undefined, and may result in GL interruption or termination."

So we need to validate and generate an error rather than allow the driver to crash.

(We need to update WebGL 2 spec and add a test to ensure the safe behavior)
 

Comment 1 by zmo@chromium.org, Jul 18 2016

Spec update and test is uploaded for review: https://github.com/KhronosGroup/WebGL/pull/1900

Comment 2 by zmo@chromium.org, Jul 19 2016

Owner: zmo@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b040628bbfbc247246ac34da5e6ef32d4fd4801a

commit b040628bbfbc247246ac34da5e6ef32d4fd4801a
Author: jmadill <jmadill@chromium.org>
Date: Fri Jul 22 15:12:26 2016

WebGL 2: Add back a failing Win/Intel UBO test.

This was lifted in https://codereview.chromium.org/2165873002/,
failing in builds since:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28New%20Intel%29/builds/1174

BUG= 628863 
TBR=zmo@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2172253002
Cr-Commit-Position: refs/heads/master@{#407162}

[modify] https://crrev.com/b040628bbfbc247246ac34da5e6ef32d4fd4801a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 4 by zmo@chromium.org, Aug 4 2016

Status: Fixed (was: Started)
https://codereview.chromium.org/2165873002/

Landed.
Components: -Internals>GPU>WebGL Blink>WebGL

Sign in to add a comment