The autofill section includes two dialogs [1] which are rendered immediately instead of lazily. The overall time to render the autofill section (with the dialogs) is about 145ms, whereas without the dialogs is about 40ms. This was revealed during profiling the force-rendering performance of the search algorithm. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html?l=71,72,119,120
Per discussion, here is an example of lazy creation of dialogs, https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search_engines_page/search_engines_page.html?l=32-34.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb83249074e527816c008e2ed661d6aefdeb6ac4 commit fb83249074e527816c008e2ed661d6aefdeb6ac4 Author: hcarmona <hcarmona@chromium.org> Date: Wed Jul 20 01:37:20 2016 [MD Settings] Lazy create dialogs in Passwords and Autofill section. BUG= 628833 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2154263004 Cr-Commit-Position: refs/heads/master@{#406442} [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js [modify] https://crrev.com/fb83249074e527816c008e2ed661d6aefdeb6ac4/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
Marking this as fixed. Dialogs are now behind dom-if.
Comment 1 by dpa...@chromium.org
, Jul 18 2016Status: Assigned (was: Untriaged)