Do we really have to?

> Do we really have to?

another one of those probably-no-but-not-really-sure-without-uma cases

Does API query reveal any usage?

apparently it doesn't have a way to count overriding a method, only calls directly into webview apis :/

c#2: In
https://developer.android.com/reference/android/webkit/WebChromeClient.html#getVideoLoadingProgressView()
we advertise that a client can override this method providing a custom view, and this view will be shown while loading.
I think we should either remove this method completely, or keep showing a view.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c

commit ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c
Author: timav <timav@chromium.org>
Date: Sat Aug 06 00:49:11 2016

Make ContentVideoView progress view visible in WebView

The progress view used to be part of ContentVideoView underlay.
In the current Spitzer implementation for WebView FullScreenView
got opaque content which now obstructs the progress bar.

This CL removes the progress bar from ContentVideoView
and makes the ContentVideoViewEmbedder responsible for
its creation and display.

As well, the progress bar remained in WebView only and has been
removed from Chrome.

BUG= 628828 
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2154883003
Cr-Commit-Position: refs/heads/master@{#410234}

[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/android_webview/java/strings/android_webview_strings.grd
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/android_webview/test/BUILD.gn
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/android_webview/test/shell/assets/full_screen_video_test.html
[add] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/android_webview/test/shell/assets/full_screen_video_test_not_preloaded.html
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/browser/android/content_video_view.cc
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/browser/android/content_video_view.h
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/browser/media/android/browser_media_player_manager.cc
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/browser/media/android/browser_surface_view_manager.cc
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewEmbedder.java
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewEmbedder.java
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/public/android/java/strings/android_content_strings.grd
[modify] https://crrev.com/ee5c228c4753bd80e1f6f14e7cbc7ee3c673b00c/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java

The assigned owner "timav@chromium.org" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot