New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628802 link

Starred by 2 users
Status: Fixed
Owner:
█ mlliu@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
█ nyquist@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Feature

Blocking:
issue 597756



Sign in to add a comment

Migrate TabControlFeature from 0.5 to 0.6

Project Member Reported by dtrainor@chromium.org, Jul 15 2016 
We need to update and move the TabControlFeature from 0.5 to 0.6, which includes the following subtasks:

1. Renaming the TabControlFeature to something a little better... not sure on this yet ;).
2. Moving it to blimp/client/core/???/
3. Connecting it to BlimpClientContext::CreateBlimpContents().
4. Connecting it to BlimpContents death (through observer?).

5. Pull SetSizeAndScale out to a different feature :).

Comment 1 by amineer@chromium.org, Jul 26 2016

Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626

commit bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626
Author: mlliu <mlliu@chromium.org>
Date: Wed Aug 10 00:39:19 2016

Migrate TabControlFeature from 0.5 to 0.6

This CL includes:
1. Moving TabControlFeature to blimp/client/core/feature/
2. Create BlimpContentsManager which creates BlimpContentsImpl, and
return a BlimpContentsImpl given a content id
3. Have BlimpClientContextImpl calls
BlimpContentsManager->CreateBlimpContents()

BUG= 628802 

Review-Url: https://codereview.chromium.org/2201433002
Cr-Commit-Position: refs/heads/master@{#410900}

[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/BUILD.gn
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/app/android/tab_control_feature_android.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/android/blimp_contents_factory.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[add] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/blimp_contents_manager.cc
[add] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/blimp_contents_manager.h
[add] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[add] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/blimp_contents_observer_unittest.cc
[rename] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/tab_control_feature.cc
[rename] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/tab_control_feature.h
[rename] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/core/contents/tab_control_feature_unittest.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/public/BUILD.gn
[add] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/public/contents/blimp_contents_observer.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/public/contents/blimp_contents_observer.h
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/bdee0b7cac3fdbcfc476ccb8f3d203a7ad58a626/blimp/engine/browser_tests/engine_browsertest.cc

Comment 3 by mlliu@chromium.org, Aug 19 2016

Blockedon: 639154
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8e9f7138e9f22d14edbe6b00f824b265fa08060

commit a8e9f7138e9f22d14edbe6b00f824b265fa08060
Author: mlliu <mlliu@chromium.org>
Date: Sat Aug 20 02:17:52 2016

Add TabControlFeature to BlimpClientContextImpl

This CL includes:
1. BlimpClientContextImpl owns the TabControlFeature, and register the
feature in its constructor.
2. When a BlimpContents is created, set a pointer to TabControlFeature
in BlimpContentsImpl.
3. Add a method to SetSizeAndScale in BlimpContents.
4. call CreateTab in BlimpClientContextImplAndroid.

BUG= 628802 

Review-Url: https://codereview.chromium.org/2255533002
Cr-Commit-Position: refs/heads/master@{#413309}

[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/BUILD.gn
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/blimp_contents_manager.cc
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/blimp_contents_manager.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/blimp_contents_observer_unittest.cc
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/blimp/client/core/contents/tab_control_feature.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/box_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/point.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/point3_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/point_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/quad_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/rect.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/rect_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/scroll_offset.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/size.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/size_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/vector2d.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/vector2d_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/geometry/vector3d_f.h
[modify] https://crrev.com/a8e9f7138e9f22d14edbe6b00f824b265fa08060/ui/gfx/transform.h

Comment 5 by dtrainor@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)
IIUC this is done.  Closing it out.

Comment 6 by mlliu@chromium.org, Aug 23 2016 

I still need to Pull SetSizeAndScale out to a different feature. but it's ok. i have another bug for it. https://bugs.chromium.org/p/chromium/issues/detail?id=639154

should i mark that as M-55?

Comment 7 by dtrainor@chromium.org, Nov 16 2016

Blockedon: -639154

Comment 8 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment