New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628795 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ICF doesn't respect section alignment

Project Member Reported by llozano@chromium.org, Jul 15 2016

Issue description

gold linker has the following bug.
ChromeOS uses icf=all.

https://sourceware.org/bugzilla/show_bug.cgi?id=17704

Do we need to disable icf? 
or backport a binutils patch? (is there one?)




 
Talked to Sri about this. There is a fix coming this week and he will backport to binutils 2.25. So, lets wait for the fix and put in ChromeOS and Android.
Can you please find out if icf can be enabled for android once we have a fix for this bug?
Status: Started (was: Assigned)
CL out for review: https://android-review.googlesource.com/#/c/262195/
Summary: ICF doesn't respect section alignment (was: gold linker has a bug in ICF)
CL merged: https://android-review.googlesource.com/#/c/292548/
Remaining steps:
-) Update Chromium OS binutils ebuild to use the new commit/tree hashes.
-) Update the toolchain prebuilts for Android.

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/257c49a287a1954c3cabd80ad6ea5395b28dbb2c

commit 257c49a287a1954c3cabd80ad6ea5395b28dbb2c
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Thu Nov 10 23:10:09 2016

sys-devel/binutils: sync to latest binutils sources from aosp.

This CL syncs binutils in chromiumos to the latest from aosp.
The commit from aosp/master being imported in this CL is:
  b8ff982 gold: make icf respect section alignment requirements.

BUG= chromium:628795 
TEST=`sudo emerge sys-devel/binutils` works.
TEST=`sudo emerge cross-i686-pc-linux-gnu/binutils` works.
TEST=`sudo emerge cross-x86_64-cros-linux-gnu/binutils` works.
TEST=`sudo emerge cross-armv7a-cros-linux-gnueabi/binutils` works.
TEST=`Tested as an epatch with https://chromium-review.googlesource.com/#/c/401891/`

Change-Id: I24019b81f9b6e88d2657c97e72ad98c452b78844
Reviewed-on: https://chromium-review.googlesource.com/410440
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[rename] https://crrev.com/257c49a287a1954c3cabd80ad6ea5395b28dbb2c/sys-devel/binutils/binutils-2.25.51-r62.ebuild

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment