New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628794 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 635951



Sign in to add a comment

Unable to integrate new V8 inspector in Node.JS 6

Project Member Reported by eostroukhov@chromium.org, Jul 15 2016

Issue description

A number of compilation errors are introduced, that come from old libstdc++ used by Node on Mac.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851972d6da7463c353d712d2cb6c1ec23fa6c4fe

commit 851972d6da7463c353d712d2cb6c1ec23fa6c4fe
Author: eostroukhov <eostroukhov@google.com>
Date: Mon Jul 18 21:35:27 2016

[DevTools] Compatibility with older STL libraries

One of the clients need to support Mac OS X version 10.7, which means that Clang compiler that support C++11 is used but the application is linked against pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG= 628794 
R=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2150333003
Cr-Commit-Position: refs/heads/master@{#406103}

[modify] https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe/third_party/WebKit/Source/platform/inspector_protocol/Collections.h
[modify] https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe/third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h
[modify] https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe/third_party/WebKit/Source/platform/inspector_protocol/String16STL.h
[modify] https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1321cc19c5cf167da9e4420256dab65c28bef2fd

commit 1321cc19c5cf167da9e4420256dab65c28bef2fd
Author: eostroukhov <eostroukhov@google.com>
Date: Tue Jul 19 17:16:15 2016

[DevTools] Node.js compatibility

1. CodeGenerator.py correctly detects directory structure.
2. Initializer lists are no longer used with std::vector

BUG= 628794 

Review-Url: https://codereview.chromium.org/2155413002
Cr-Commit-Position: refs/heads/master@{#406302}

[modify] https://crrev.com/1321cc19c5cf167da9e4420256dab65c28bef2fd/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
[modify] https://crrev.com/1321cc19c5cf167da9e4420256dab65c28bef2fd/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Status: Fixed (was: Started)
Blocking: 635951

Sign in to add a comment