The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f7f2a6d3baca46a3271e038d574f9187f08fa52

commit 8f7f2a6d3baca46a3271e038d574f9187f08fa52
Author: erg <erg@chromium.org>
Date: Thu Nov 03 00:20:20 2016

mash: remove the LockStateControllerDelegate.

This removes the LockStateControllerDelegate and mojoifys/renames it
into the ShutdownClient, which is exported by chrome.

While in the long term, we'll want to move the code that's currently in
ShutdownClient into ash (and either use CrosSettings in ash or send
messages to a dedicated CrosSettings service), the chromeos device
settings code is sufficiently intertangled with the browser process that
it isn't happening anytime soon. (See crbug.com/446937)

BUG= 628792 
TEST=covered by converted ash_unittests; manually tested the mojo call in non-mash ash.

Review-Url: https://codereview.chromium.org/2471643002
Cr-Commit-Position: refs/heads/master@{#429471}

[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/BUILD.gn
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/public/interfaces/shutdown.mojom
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/shell.cc
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/test/BUILD.gn
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/test/lock_state_controller_test_api.cc
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/test/lock_state_controller_test_api.h
[delete] https://crrev.com/b44d20f05d91a9c0ea51d6189c1bf9990c14db86/ash/test/test_lock_state_controller_delegate.cc
[delete] https://crrev.com/b44d20f05d91a9c0ea51d6189c1bf9990c14db86/ash/test/test_lock_state_controller_delegate.h
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/test/test_shutdown_client.cc
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/test/test_shutdown_client.h
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/wm/lock_state_controller.h
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/wm/lock_state_controller_unittest.cc
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/wm/shutdown_client_proxy.cc
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/ash/wm/shutdown_client_proxy.h
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/chrome/app/mash/chrome_mash_content_browser_manifest_overlay.json
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/chrome/browser/chromeos/chrome_interface_factory.cc
[modify] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/chrome/browser/chromeos/power/login_lock_state_notifier.cc
[delete] https://crrev.com/b44d20f05d91a9c0ea51d6189c1bf9990c14db86/chrome/browser/chromeos/power/session_state_controller_delegate_chromeos.h
[rename] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/chrome/browser/chromeos/power/shutdown_client_impl.cc
[add] https://crrev.com/8f7f2a6d3baca46a3271e038d574f9187f08fa52/chrome/browser/chromeos/power/shutdown_client_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f152f1d2e35a35a726a3891c00a764de144b39

commit d9f152f1d2e35a35a726a3891c00a764de144b39
Author: jamescook <jamescook@chromium.org>
Date: Tue Nov 15 00:53:08 2016

chromeos: Move device shutdown handling out of chrome into ash

Historically device shutdown was handled in chrome because it needed to check
a device "reboot on shutdown" policy during the shutdown process. Under mustash
it is possible to quit the chrome browser and leave ash running, but the old
code required launching chrome in order to shut down.

Moving the code into ash also reduces ash/chrome dependencies and simplifies
the SystemTrayDelegate code I'm trying to refactor.

* The system tray shutdown button computes its "shutdown" vs "reboot" each time
the menu is opened. It no longer changes its tooltip if the policy changed while
the menu was open. The old behavior seemed unnecessary, and doing it this way
avoids a set of policy observers in ash.
* Chrome observes the shutdown policy via ShutdownPolicyHandler. It sends the
initial value to ash via the ash::mojom::ShutdownController mojo interface.
Subsequent policy updates are sent over the same interface.

This partially reverts the ShutdownClient implementation introduced in
https://codereview.chromium.org/2471643002

BUG= 647412 , 628792 
TEST=ash_unittests, chrome unit_tests and browser_tests (ShutdownPolicy*) and
manual testing on device

Review-Url: https://codereview.chromium.org/2497123002
Cr-Commit-Position: refs/heads/master@{#432035}

[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/BUILD.gn
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/mojo_interface_factory.cc
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/shutdown_controller.cc
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/shutdown_controller.h
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/common/system/chromeos/shutdown_policy_observer.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/date/date_default_view.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/date/date_default_view.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tiles_default_view.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tiles_default_view.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tray_tiles.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tiles/tray_tiles.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/wm_shell.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/common/wm_shell.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/mus/manifest.json
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/public/interfaces/shutdown.mojom
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/shell.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/test/BUILD.gn
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/test/lock_state_controller_test_api.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/test/lock_state_controller_test_api.h
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/test/test_shutdown_client.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/test/test_shutdown_client.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/wm/lock_state_controller.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/ash/wm/lock_state_controller_unittest.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/wm/shutdown_client_proxy.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/ash/wm/shutdown_client_proxy.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/app/mash/chrome_mash_content_browser_manifest_overlay.json
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/chrome_interface_factory.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/chrome/browser/chromeos/power/shutdown_client_impl.cc
[delete] https://crrev.com/fd707bac822a15eb606878c7610a62cb53d0f368/chrome/browser/chromeos/power/shutdown_client_impl.h
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_forwarder.cc
[add] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_forwarder.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_handler.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_handler.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/d9f152f1d2e35a35a726a3891c00a764de144b39/chrome/browser/ui/webui/chromeos/login/oobe_ui.h

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This class doesn't exist anymore.