See b/29248657.
Accidentally used the buganizer ID for this issue. Here are the CLs landed so far for this: https://codereview.chromium.org/2128913002/ https://codereview.chromium.org/2144593004/
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Gah, also merged to M53 with the wrong bug ID: https://codereview.chromium.org/2163443002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc32bf38b38897794b71fc9b0dd19f591a0bb4b5 commit bc32bf38b38897794b71fc9b0dd19f591a0bb4b5 Author: Ben Kwa <kenobi@google.com> Date: Mon Jul 18 21:58:22 2016 Fix whitespace in intent_helper.mojom. BUG= 628788 Review-Url: https://codereview.chromium.org/2144593004 Cr-Commit-Position: refs/heads/master@{#405324} (cherry picked from commit a21a95e7172c3fc4c82703a00391c516198ed2f4) Review URL: https://codereview.chromium.org/2160053002 . Cr-Commit-Position: refs/branch-heads/2785@{#202} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/bc32bf38b38897794b71fc9b0dd19f591a0bb4b5/components/arc/common/intent_helper.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5acc3b7599948290a46f7f9003e7a1cc5b466590 commit 5acc3b7599948290a46f7f9003e7a1cc5b466590 Author: kenobi <kenobi@chromium.org> Date: Tue Jul 19 15:49:42 2016 [arc-intents] Remove SSP matching; add unit tests. - As discussed with elijahtaylor@ and yusukes@, don't attempt matching for scheme-specific parts. Extracting an SSP from a chrome URL is fraught, and SSPs don't really apply to http/https URLs anyway. - Add unit tests for the IntentFilter class. BUG= 628788 Review-Url: https://codereview.chromium.org/2156683002 Cr-Commit-Position: refs/heads/master@{#406283} [modify] https://crrev.com/5acc3b7599948290a46f7f9003e7a1cc5b466590/components/arc/BUILD.gn [modify] https://crrev.com/5acc3b7599948290a46f7f9003e7a1cc5b466590/components/arc/common/intent_helper.mojom [modify] https://crrev.com/5acc3b7599948290a46f7f9003e7a1cc5b466590/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/5acc3b7599948290a46f7f9003e7a1cc5b466590/components/arc/intent_helper/intent_filter.h [add] https://crrev.com/5acc3b7599948290a46f7f9003e7a1cc5b466590/components/arc/intent_helper/intent_filter_unittest.cc [modify] https://crrev.com/5acc3b7599948290a46f7f9003e7a1cc5b466590/components/components_tests.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aac6daf43069ac480e64e153e742de28d0b2843 commit 0aac6daf43069ac480e64e153e742de28d0b2843 Author: Ben Kwa <kenobi@google.com> Date: Wed Jul 20 18:49:36 2016 [arc-intents] Remove SSP matching; add unit tests. - As discussed with elijahtaylor@ and yusukes@, don't attempt matching for scheme-specific parts. Extracting an SSP from a chrome URL is fraught, and SSPs don't really apply to http/https URLs anyway. - Add unit tests for the IntentFilter class. BUG= 628788 Review-Url: https://codereview.chromium.org/2156683002 Cr-Commit-Position: refs/heads/master@{#406283} (cherry picked from commit 5acc3b7599948290a46f7f9003e7a1cc5b466590) Review URL: https://codereview.chromium.org/2161073004 . Cr-Commit-Position: refs/branch-heads/2785@{#248} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/0aac6daf43069ac480e64e153e742de28d0b2843/components/arc/BUILD.gn [modify] https://crrev.com/0aac6daf43069ac480e64e153e742de28d0b2843/components/arc/common/intent_helper.mojom [modify] https://crrev.com/0aac6daf43069ac480e64e153e742de28d0b2843/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/0aac6daf43069ac480e64e153e742de28d0b2843/components/arc/intent_helper/intent_filter.h [add] https://crrev.com/0aac6daf43069ac480e64e153e742de28d0b2843/components/arc/intent_helper/intent_filter_unittest.cc [modify] https://crrev.com/0aac6daf43069ac480e64e153e742de28d0b2843/components/components_tests.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8692456882c5cde70eb246fc11b9372032d3992 commit d8692456882c5cde70eb246fc11b9372032d3992 Author: kenobi <kenobi@chromium.org> Date: Wed Jul 20 19:51:21 2016 [arc-intents] Deal correctly with default ports. Loosen the match requirements for ports so that URLs are matched regardless of whether the port was implicitly (i.e. the default) or explicitly specified. This provides an optimistic filter that ensures the disambiguation code doesn't get skipped in the case of potential matches. BUG= 628788 Review-Url: https://codereview.chromium.org/2159203003 Cr-Commit-Position: refs/heads/master@{#406644} [modify] https://crrev.com/d8692456882c5cde70eb246fc11b9372032d3992/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/d8692456882c5cde70eb246fc11b9372032d3992/components/arc/intent_helper/intent_filter_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fef25947fb5aa192eb5542c42231736e08b22c2 commit 5fef25947fb5aa192eb5542c42231736e08b22c2 Author: Ben Kwa <kenobi@google.com> Date: Wed Jul 20 19:58:50 2016 [arc-intents] Deal correctly with default ports. Loosen the match requirements for ports so that URLs are matched regardless of whether the port was implicitly (i.e. the default) or explicitly specified. This provides an optimistic filter that ensures the disambiguation code doesn't get skipped in the case of potential matches. BUG= 628788 Review-Url: https://codereview.chromium.org/2159203003 Cr-Commit-Position: refs/heads/master@{#406644} (cherry picked from commit d8692456882c5cde70eb246fc11b9372032d3992) Review URL: https://codereview.chromium.org/2166933002 . Cr-Commit-Position: refs/branch-heads/2785@{#249} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/5fef25947fb5aa192eb5542c42231736e08b22c2/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/5fef25947fb5aa192eb5542c42231736e08b22c2/components/arc/intent_helper/intent_filter_unittest.cc
Closing old bug
Comment 1 by kenobi@chromium.org
, Jul 15 2016