New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628783 link

Starred by 1 user
Status: Fixed
Owner:
dpranke@chromium.org
Closed: Jul 2016
Cc:
jam@chromium.org
dbeam@chromium.org
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

MB/GN's implementation of analyze doesn't work right for files listed under data directories

Project Member Reported by dpranke@chromium.org, Jul 15 2016 
MB/GN's implementation of analyze doesn't work right for files listed under data directories.

In other words, if //chrome/test:browser_tests lists `data = "//chrome/test/data/"`, and you modify //chrome/test/data/foo.html, analyze should conclude that browser_tests needs to be re-run. But, if you run `gn refs out/foo //chrome/test/data/foo.html` right now, it will think that nothing uses that file, because it doesn't connect the file to the directory.

We should fix that, because otherwise listing directories in data is less useful than it could be (it's still useful for isolates even now, though).

See https://codereview.chromium.org/2152523002/diff/1/testing/buildbot/trybot_analyze_config.json for an example of this.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/385bdb40ca9b717653a3a32064afa67df50d5e97

commit 385bdb40ca9b717653a3a32064afa67df50d5e97
Author: dbeam <dbeam@chromium.org>
Date: Sat Jul 16 00:03:56 2016

Exclude some WebUI resources from analysis until GN considers data files

R=dpranke@chromium.org
BUG= 628783 

Review-Url: https://codereview.chromium.org/2152523002
Cr-Commit-Position: refs/heads/master@{#405905}

[modify] https://crrev.com/385bdb40ca9b717653a3a32064afa67df50d5e97/testing/buildbot/trybot_analyze_config.json

Comment 2 by dpranke@chromium.org, Jul 17 2016

Labels: -Pri-2 Pri-1

Comment 3 by dpranke@chromium.org, Jul 19 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/267b1de99ba7baf7150d4e8e1b9e42969c16c343

commit 267b1de99ba7baf7150d4e8e1b9e42969c16c343
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 20 22:21:54 2016

Make `gn refs` handle files in data directories properly.

If a target specified `data = [ "test/" ]` and you ran
`gn refs out/Default //foo //foo/test/bar.cc`, gn refs would
incorrectly think that nothing referenced bar.cc. This patch
fixes that.

R=brettw@chromium.org
BUG= 628783 

Review-Url: https://codereview.chromium.org/2160383002
Cr-Commit-Position: refs/heads/master@{#406689}

[modify] https://crrev.com/267b1de99ba7baf7150d4e8e1b9e42969c16c343/tools/gn/command_refs.cc

Comment 6 by dpranke@chromium.org, Jul 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment