New issue
Advanced search Search tips

Issue 628781 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 628685



Sign in to add a comment

Remove [+ADD CARD] button when merchant requests only Android Pay

Project Member Reported by rouslan@chromium.org, Jul 15 2016

Issue description

^^^^
 

Comment 1 Deleted

Screenshot_20160715-165408.png
102 KB View Download
Labels: Merge-Request-53 M-53
Would like to merge 4f0ae181161cdec13eb29cc8753aaa83c587a332 to M-53.

Comment 5 by dimu@google.com, Jul 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9676b63689e070ff43434b27a590c47d424f706d

commit 9676b63689e070ff43434b27a590c47d424f706d
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jul 22 16:40:34 2016

[Merge M-53] Don't show [+ ADD CARD] button for merchant that does not take cards.

If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1

BUG= 628781 

Review-Url: https://codereview.chromium.org/2158453003
Cr-Commit-Position: refs/heads/master@{#406645}
(cherry picked from commit 4f0ae181161cdec13eb29cc8753aaa83c587a332)

Review URL: https://codereview.chromium.org/2179483003 .

Cr-Commit-Position: refs/branch-heads/2785@{#301}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9676b63689e070ff43434b27a590c47d424f706d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/9676b63689e070ff43434b27a590c47d424f706d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/9676b63689e070ff43434b27a590c47d424f706d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in M53-53.0.2785.34 build
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment