New issue
Advanced search Search tips

Issue 628756 link

Starred by 2 users
Status: Assigned
Owner:
llozano@chromium.org
Cc:
dpranke@chromium.org
steve...@chromium.org
achuith@chromium.org
ihf@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

GN: Chrome on Chrome OS compiles with different ldflags

Project Member Reported by steve...@chromium.org, Jul 15 2016 
The following ldflags are different in GYP vs GN:

GYP: -Wl,-O2  (GN: -Wl,-O1)
GYP: -Wl,--icf=all  (GN: -Wl,--icf=safe)

The following ldflags are set in GYP bug not GN:

-Wl,-uIsHeapProfilerRunning,-uProfilerStart

Comment 1 by steve...@chromium.org, Jul 15 2016

Cc: dpranke@chromium.org ihf@chromium.org achuith@chromium.org
The icf=all vs icf=safe issue was causing a 5% increase in Chrome binary size ( issue 628441 ). It is being addressed here:

https://codereview.chromium.org/2153223002/

Comment 2 by steve...@chromium.org, Jul 15 2016 

Setting -O2 vs -O1 only decreases the binary size by 624. I do not have a good way to test whether or not it impacts performance.

Comment 3 by steve...@chromium.org, Jul 15 2016 

Also in GYP but not GN:

-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi
-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl
-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv

And in GN but not GYP:

-Wl,--fatal-warnings
-Wl,--thread-count=4
-Wl,--threads

Comment 4 by steve...@chromium.org, Jul 15 2016 

Note: All of these are for 'samus' (amd64).

I've attached the chrome_initial.ninja files for GN and GYP (same ones I attached to  issue 628441 )
chrome_initial.ninja.gn
516 KB Download
chrome_initial.ninja.gyp
144 KB Download

Comment 5 by dpranke@chromium.org, Sep 22 2016

Labels: -Proj-GN-Migration
Clearing the Proj-GN-Migration label since it didn't block the GN migration (I'm trying to figure out what, if any GYP/GN-related tasks might be left).
►

Sign in to add a comment