Delete channel abstraction in cc. |
||||
Issue descriptionSince blimp is working on moving the process boundary to be at the LayerTreeHost/Client level (between cc and blimp), the threaded vs remote channel concept doesn't need to exist. I think we should keep ProxyMain vs ProxyImpl that is a very good split. But unless we're removing SingleThreadProxy, I don't see the reason for the channel abstraction between ProxyMain/Impl, they can just posttask directly. When's the right time to delete RemoteChannel and work on merging ThreadedChannel into the ProxyMain/Impl?
,
Jul 15 2016
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12020cd40a727019ace7f438018018f266538ba7 commit 12020cd40a727019ace7f438018018f266538ba7 Author: khushalsagar <khushalsagar@chromium.org> Date: Mon Nov 21 09:22:48 2016 cc: Delete channel abstraction between proxies. The abstraction is now unnecessary. It was added to allow a mode where these components may not be across threads, which is no longer needed. The proxies can talk to each other directly. BUG= 628746 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2513863002 Cr-Commit-Position: refs/heads/master@{#433496} [modify] https://crrev.com/12020cd40a727019ace7f438018018f266538ba7/cc/BUILD.gn [delete] https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f/cc/test/fake_channel_impl.cc [delete] https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f/cc/test/fake_channel_impl.h [modify] https://crrev.com/12020cd40a727019ace7f438018018f266538ba7/cc/test/layer_tree_test.cc [delete] https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f/cc/trees/channel_impl.h [delete] https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f/cc/trees/channel_main.h [modify] https://crrev.com/12020cd40a727019ace7f438018018f266538ba7/cc/trees/layer_tree_host_in_process.cc [modify] https://crrev.com/12020cd40a727019ace7f438018018f266538ba7/cc/trees/proxy_impl.cc [modify] https://crrev.com/12020cd40a727019ace7f438018018f266538ba7/cc/trees/proxy_impl.h [modify] https://crrev.com/12020cd40a727019ace7f438018018f266538ba7/cc/trees/proxy_main.cc [modify] https://crrev.com/12020cd40a727019ace7f438018018f266538ba7/cc/trees/proxy_main.h [delete] https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f/cc/trees/threaded_channel.cc [delete] https://crrev.com/80ff2be8079778b471c4afdf0a3061f5f088376f/cc/trees/threaded_channel.h
,
Nov 21 2016
,
Dec 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by khushals...@chromium.org
, Jul 15 2016