New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628737 link

Starred by 2 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Nov 2016
Cc:
calamity@chromium.org
tbuck...@chromium.org
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[history-nav] change "history" to "chrome history" in the nav

Project Member Reported by bettes@chromium.org, Jul 15 2016 
I think we need to rename the "History" tab to something more specific, given that the Narnia string below says that this page isn't the *only* place for your history. 

I propose "Chrome history", open to suggestions but I think "history" should be changed
SPEC history_sidenav.png
80.9 KB View Download

Comment 1 by tsergeant@chromium.org, Jul 20 2016

Cc: -tsergeant@chromium.org tbuck...@chromium.org
Owner: tsergeant@chromium.org
This makes sense, I'm happy to implement this.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f859ef536a5221be526aa5ac028376cfd3a4d2fa

commit f859ef536a5221be526aa5ac028376cfd3a4d2fa
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Jul 20 05:03:19 2016

MD History: Change sidebar menu item from "History" to "Chrome history"

BUG= 628737 

Review-Url: https://codereview.chromium.org/2168513003
Cr-Commit-Position: refs/heads/master@{#406500}

[modify] https://crrev.com/f859ef536a5221be526aa5ac028376cfd3a4d2fa/chrome/app/generated_resources.grd

Comment 3 by calamity@chromium.org, Jul 22 2016

Status: Fixed (was: Assigned)

Comment 4 by tbuck...@chromium.org, Jul 22 2016

Cc: tsergeant@chromium.org
Labels: -Pri-2 Pri-3
Owner: bettes@chromium.org
Status: Assigned (was: Fixed)
Just to capture it here, dbeam@ had suggested "All history". I have a preference for that over "Chrome History".

@bettes, thoughts?

Comment 5 by tsergeant@chromium.org, Nov 18 2016 

Does anyone still have any preferences about this, or can this bug go back to Fixed?

Comment 6 by bettes@chromium.org, Nov 22 2016

Owner: tsergeant@chromium.org
Er, Im not really sure the rationale behind "All history" given comment #1 so marking as Fixed sounds fine with me

Comment 7 by tsergeant@chromium.org, Nov 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment