New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628731 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Custom Formatters] Please increase maxCustomPreviewRecursionDepth in InjectedScriptSource.js

Reported by antonin....@gmail.com, Jul 15 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Steps to reproduce the problem:
I'm getting "Custom Formatter Failed: Too deep hierarchy of inlined custom previews" error in console when rendering more complex custom formatters via cljs-devtools[1].

[1] https://github.com/binaryage/cljs-devtools

What is the expected behavior?
I assume this limit is there to prevent infinite expansion of inlined custom formatters and limit overall complexity of generated DOM in console.

But I have valid situations when I hit this limit. cljs-devtools tries to display nested data structures in a compact way - that can lead to deeper hierarchies because rendering  code wraps some items in extra divs/spans/tables for better control over css styling. In other words the current depth limit of 20 is too low for my use. 

I would like you to increase it at least to 100 or better make it user-configurable: e.g. via window.devtoolsFormatters.maxCustomPreviewRecursionDepth or via customObjectConfig.

What went wrong?
Custom Formatter Failed: Too deep hierarchy of inlined custom previews

Did this work before? No 

Chrome version: 54.0.2795.0  Channel: canary
OS Version: OS X 10.11.6
Flash Version: 

Also the error message can be confusing at first. It does not mention which custom formatter caused the issue and how much is "too deep". Also it mentions "inlined custom previews", but the hierarchy depth is measured for passed JSON-ML which may or may not contain any inlined custom previews (object refs).

The error should be something like:
"Encountered deep hierarchy while rendering custom formatter for <js-object>. Passed JSON-ML hit the depth limit of <maxCustomPreviewRecursionDepth> (including inlined custom previews)."
 

Comment 1 by alph@chromium.org, Jul 15 2016

Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Archived (was: Assigned)
Bulk DevTools triage, closing low priority issues with no action plan.

Sign in to add a comment