New issue
Advanced search Search tips

Issue 628718 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

referrerpolicy IDL attributes are miscapitalized

Project Member Reported by est...@chromium.org, Jul 15 2016

Issue description

Per WHATWG HTML, the attribute should be referrerPolicy, not referrerpolicy. Womp womp.
 

Comment 1 by est...@chromium.org, Jul 19 2016

Status: Fixed (was: Assigned)

Comment 2 by est...@chromium.org, Jul 19 2016

Status: Started (was: Fixed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c3b9e79b591bdf2fdea29c1f44f455f124f2539

commit 3c3b9e79b591bdf2fdea29c1f44f455f124f2539
Author: estark <estark@chromium.org>
Date: Tue Jul 19 18:03:19 2016

Fix referrerPolicy IDL attribute spelling

In the grand tradition of trivial HTTP-referrer-related misspellings
that haunt the web forever, I miscapitalized the referrerPolicy IDL
attribute. This CL fixes the mistake for compatibility with Firefox and
the spec (see for example
https://html.spec.whatwg.org/multipage/semantics.html#the-a-element).

BUG= 628718 

Review-Url: https://codereview.chromium.org/2150393003
Cr-Commit-Position: refs/heads/master@{#406311}

[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/Source/core/html/HTMLAnchorElement.idl
[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/Source/core/html/HTMLAreaElement.idl
[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/Source/core/html/HTMLIFrameElement.idl
[modify] https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539/third_party/WebKit/Source/core/html/HTMLImageElement.idl

Comment 4 by est...@chromium.org, Jul 19 2016

Status: Fixed (was: Started)

Comment 5 by est...@chromium.org, Jul 22 2016

Labels: Merge-Request-52 Merge-Request-53
This fix has made it into Canary and I've verified that Canary now passes the relevant web-platform-tests.

I'm requesting merges to M53 and M52, as per discussion in https://groups.google.com/a/chromium.org/d/msg/blink-dev/KmpKQhweJQY/K1q07xDSAQAJ

In summary, this is a fix to a new feature (with likely low usage) to bring Chrome's implementation into compatibility with Firefox and the spec.

Comment 6 by dimu@google.com, Jul 22 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M52, manual review required.

Comment 7 by dimu@google.com, Jul 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 8 by gov...@chromium.org, Jul 22 2016

M52 is already in Stable for Desktop and bar is VERY high.
If change is well baked in canary, safe to merge and critical for M52, then only we can take it for M52. Could you please confirm it is a safe merge and important for M52?

Comment 9 by est...@chromium.org, Jul 22 2016

The change just changes a single character in an IDL attribute, and doesn't touch any (non-generated) code. So it should be a safe merge. As for importance, since this is a new feature, we suspect there is very low usage currently but developers will be starting to use it soon, so we would really like to avoid a bunch of code getting shipped in the next few weeks that is subtly incompatible with other browsers.
Cc: awhalley@chromium.org
Labels: -Merge-Review-52 Merge-Approved-52
Thank you estark@. Approving merge to M52 branch 2743 based on comment #5 & #9. Please merge ASAP.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7036101e339378de1f4d98ff9da87ed7b1a6eeb

commit f7036101e339378de1f4d98ff9da87ed7b1a6eeb
Author: Emily Stark <estark@google.com>
Date: Fri Jul 22 02:54:35 2016

Fix referrerPolicy IDL attribute spelling

In the grand tradition of trivial HTTP-referrer-related misspellings
that haunt the web forever, I miscapitalized the referrerPolicy IDL
attribute. This CL fixes the mistake for compatibility with Firefox and
the spec (see for example
https://html.spec.whatwg.org/multipage/semantics.html#the-a-element).

BUG= 628718 

Review-Url: https://codereview.chromium.org/2150393003
Cr-Commit-Position: refs/heads/master@{#406311}
(cherry picked from commit 3c3b9e79b591bdf2fdea29c1f44f455f124f2539)

Review URL: https://codereview.chromium.org/2168283003 .

Cr-Commit-Position: refs/branch-heads/2785@{#279}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/Source/core/html/HTMLAnchorElement.idl
[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/Source/core/html/HTMLAreaElement.idl
[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/Source/core/html/HTMLIFrameElement.idl
[modify] https://crrev.com/f7036101e339378de1f4d98ff9da87ed7b1a6eeb/third_party/WebKit/Source/core/html/HTMLImageElement.idl

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1374ba4252ea2f378c935e48233608e2dea09550

commit 1374ba4252ea2f378c935e48233608e2dea09550
Author: Emily Stark <estark@google.com>
Date: Fri Jul 22 03:07:38 2016

Fix referrerPolicy IDL attribute spelling

In the grand tradition of trivial HTTP-referrer-related misspellings
that haunt the web forever, I miscapitalized the referrerPolicy IDL
attribute. This CL fixes the mistake for compatibility with Firefox and
the spec (see for example
https://html.spec.whatwg.org/multipage/semantics.html#the-a-element).

BUG= 628718 

Review-Url: https://codereview.chromium.org/2150393003
Cr-Commit-Position: refs/heads/master@{#406311}
(cherry picked from commit 3c3b9e79b591bdf2fdea29c1f44f455f124f2539)

Review URL: https://codereview.chromium.org/2172923002 .

Cr-Commit-Position: refs/branch-heads/2743@{#686}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/Source/core/html/HTMLAnchorElement.idl
[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/Source/core/html/HTMLAreaElement.idl
[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/Source/core/html/HTMLIFrameElement.idl
[modify] https://crrev.com/1374ba4252ea2f378c935e48233608e2dea09550/third_party/WebKit/Source/core/html/HTMLImageElement.idl

Sign in to add a comment