New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628711 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Physical Web uses new apis

Project Member Reported by cco3@chromium.org, Jul 15 2016

Issue description

We are using apis that are above the minimum (16).  Need to clean this up.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb5deec916198eed2b2edf2621fb7142116faa8

commit bfb5deec916198eed2b2edf2621fb7142116faa8
Author: cco3 <cco3@chromium.org>
Date: Fri Jul 15 22:08:54 2016

Remove Comparable interface from UrlInfo

There are different ways we compare the UrlInfo class.  There is no
reason for it to be comparable instead of just using a custom
Comparator each time as needed (as we already do).

BUG= 628711 

Review-Url: https://codereview.chromium.org/2152323002
Cr-Commit-Position: refs/heads/master@{#405875}

[modify] https://crrev.com/bfb5deec916198eed2b2edf2621fb7142116faa8/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java
[modify] https://crrev.com/bfb5deec916198eed2b2edf2621fb7142116faa8/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java

Comment 2 by cco3@chromium.org, Jul 18 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1352ffd4b0490107518c8e4bf04ef4ae4682de97

commit 1352ffd4b0490107518c8e4bf04ef4ae4682de97
Author: cco3 <cco3@chromium.org>
Date: Mon Jul 18 17:58:04 2016

Stop using Numeric.compare(x,y) in Physical Web

Double.compare and Long.compare were introduced in api 19, but the
minimum is api 16.  This change uses compareTo instead.

BUG= 628711 

Review-Url: https://codereview.chromium.org/2157663002
Cr-Commit-Position: refs/heads/master@{#406032}

[modify] https://crrev.com/1352ffd4b0490107518c8e4bf04ef4ae4682de97/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

Sign in to add a comment